Skip to content

Commit 5b42ec4

Browse files
ynezzclaudiubeznea
authored andcommitted
net: macb: support of_get_mac_address new ERR_PTR error
There was NVMEM support added directly to of_get_mac_address, and it uses nvmem_get_mac_address under the hood, so we can remove it. As of_get_mac_address can now return ERR_PTR encoded error values, adjust to that as well. Signed-off-by: Petr Štetiar <ynezz@true.cz> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent c387e4c commit 5b42ec4

1 file changed

Lines changed: 5 additions & 7 deletions

File tree

drivers/net/ethernet/cadence/macb_main.c

Lines changed: 5 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -4174,15 +4174,13 @@ static int macb_probe(struct platform_device *pdev)
41744174
bp->rx_intr_mask |= MACB_BIT(RXUBR);
41754175

41764176
mac = of_get_mac_address(np);
4177-
if (mac) {
4177+
if (PTR_ERR(mac) == -EPROBE_DEFER) {
4178+
err = -EPROBE_DEFER;
4179+
goto err_out_free_netdev;
4180+
} else if (!IS_ERR(mac)) {
41784181
ether_addr_copy(bp->dev->dev_addr, mac);
41794182
} else {
4180-
err = nvmem_get_mac_address(&pdev->dev, bp->dev->dev_addr);
4181-
if (err) {
4182-
if (err == -EPROBE_DEFER)
4183-
goto err_out_free_netdev;
4184-
macb_get_hwaddr(bp);
4185-
}
4183+
macb_get_hwaddr(bp);
41864184
}
41874185

41884186
err = of_get_phy_mode(np);

0 commit comments

Comments
 (0)