Skip to content

Commit 52cab8a

Browse files
LeSpockyambarus
LeSpocky
authored and
ambarus
committed
ARM: dts: at91: Fix schema warnings for pwm-leds
The node names for devices using the pwm-leds driver follow a certain naming scheme (now). Parent node name is not enforced, but recommended by DT project. DTC arch/arm/boot/dts/at91-kizbox2-2.dt.yaml CHECK arch/arm/boot/dts/at91-kizbox2-2.dt.yaml /home/alex/build/linux/arch/arm/boot/dts/at91-kizbox2-2.dt.yaml: pwm_leds: 'blue', 'green', 'red' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml DTC arch/arm/boot/dts/at91-kizbox3-hs.dt.yaml CHECK arch/arm/boot/dts/at91-kizbox3-hs.dt.yaml /home/alex/build/linux/arch/arm/boot/dts/at91-kizbox3-hs.dt.yaml: pwm_leds: 'blue', 'green', 'red', 'white' do not match any of the regexes: '^led(-[0-9a-f]+)?$', 'pinctrl-[0-9]+' From schema: /home/alex/src/linux/leds/Documentation/devicetree/bindings/leds/leds-pwm.yaml (Warnings above are for armv7 only, armv5 would produce similar warnings.) Signed-off-by: Alexander Dahl <post@lespocky.de> Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com> Link: https://lore.kernel.org/r/20201005203451.9985-6-post@lespocky.de (cherry picked from commit 997ebd6) Signed-off-by: Tudor Ambarus <tudor.ambarus@microchip.com>
1 parent e0d5a4d commit 52cab8a

7 files changed

Lines changed: 36 additions & 36 deletions

File tree

‎arch/arm/boot/dts/at91-kizbox.dts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -48,31 +48,31 @@
4848
};
4949
};
5050

51-
pwm_leds {
51+
led-controller {
5252
compatible = "pwm-leds";
5353

54-
network_green {
54+
led-1 {
5555
label = "pwm:green:network";
5656
pwms = <&tcb_pwm 2 10000000 PWM_POLARITY_INVERTED>;
5757
max-brightness = <255>;
5858
linux,default-trigger = "default-on";
5959
};
6060

61-
network_red {
61+
led-2 {
6262
label = "pwm:red:network";
6363
pwms = <&tcb_pwm 4 10000000 PWM_POLARITY_INVERTED>;
6464
max-brightness = <255>;
6565
linux,default-trigger = "default-on";
6666
};
6767

68-
user_green {
68+
led-3 {
6969
label = "pwm:green:user";
7070
pwms = <&tcb_pwm 0 10000000 PWM_POLARITY_INVERTED>;
7171
max-brightness = <255>;
7272
linux,default-trigger = "default-on";
7373
};
7474

75-
user_red {
75+
led-4 {
7676
label = "pwm:red:user";
7777
pwms = <&tcb_pwm 1 10000000 PWM_POLARITY_INVERTED>;
7878
max-brightness = <255>;

‎arch/arm/boot/dts/at91-kizbox2-common.dtsi‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -58,24 +58,24 @@
5858
};
5959
};
6060

61-
pwm_leds {
61+
led-controller {
6262
compatible = "pwm-leds";
6363

64-
blue {
64+
led-1 {
6565
label = "pwm:blue:user";
6666
pwms = <&pwm0 2 10000000 0>;
6767
max-brightness = <255>;
6868
linux,default-trigger = "none";
6969
};
7070

71-
green {
71+
led-2 {
7272
label = "pwm:green:user";
7373
pwms = <&pwm0 1 10000000 0>;
7474
max-brightness = <255>;
7575
linux,default-trigger = "default-on";
7676
};
7777

78-
red {
78+
led-3 {
7979
label = "pwm:red:user";
8080
pwms = <&pwm0 0 10000000 0>;
8181
max-brightness = <255>;

‎arch/arm/boot/dts/at91-kizbox3-hs.dts‎

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -15,40 +15,40 @@
1515
model = "Overkiz KIZBOX3-HS";
1616
compatible = "overkiz,kizbox3-hs", "atmel,sama5d2", "atmel,sama5";
1717

18-
pwm_leds {
18+
led-controller-1 {
1919
status = "okay";
2020

21-
red {
21+
led-1 {
2222
status = "okay";
2323
};
2424

25-
green {
25+
led-2 {
2626
status = "okay";
2727
};
2828

29-
blue {
29+
led-3 {
3030
status = "okay";
3131
};
3232

33-
white {
33+
led-4 {
3434
status = "okay";
3535
};
3636
};
3737

38-
leds {
38+
led-controller-2 {
3939
compatible = "gpio-leds";
4040
pinctrl-names = "default";
4141
pinctrl-0 = <&pinctrl_led_red
4242
&pinctrl_led_white>;
4343
status = "okay";
4444

45-
red {
45+
led-5 {
4646
label = "pio:red:user";
4747
gpios = <&pioA PIN_PB1 GPIO_ACTIVE_HIGH>;
4848
default-state = "off";
4949
};
5050

51-
white {
51+
led-6 {
5252
label = "pio:white:user";
5353
gpios = <&pioA PIN_PB8 GPIO_ACTIVE_HIGH>;
5454
default-state = "off";

‎arch/arm/boot/dts/at91-kizbox3_common.dtsi‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@
6262
regulator-always-on;
6363
};
6464

65-
pwm_leds {
65+
led-controller-1 {
6666
compatible = "pwm-leds";
6767
pinctrl-names = "default";
6868
pinctrl-0 = <&pinctrl_pwm0_pwm_h0
@@ -71,30 +71,30 @@
7171
&pinctrl_pwm0_pwm_h3>;
7272
status = "disabled";
7373

74-
red {
74+
led-1 {
7575
label = "pwm:red:user";
7676
pwms = <&pwm0 0 10000000 0>;
7777
max-brightness = <255>;
7878
linux,default-trigger = "default-on";
7979
status = "disabled";
8080
};
8181

82-
green {
82+
led-2 {
8383
label = "pwm:green:user";
8484
pwms = <&pwm0 1 10000000 0>;
8585
max-brightness = <255>;
8686
linux,default-trigger = "default-on";
8787
status = "disabled";
8888
};
8989

90-
blue {
90+
led-3 {
9191
label = "pwm:blue:user";
9292
pwms = <&pwm0 2 10000000 0>;
9393
max-brightness = <255>;
9494
status = "disabled";
9595
};
9696

97-
white {
97+
led-4 {
9898
label = "pwm:white:user";
9999
pwms = <&pwm0 3 10000000 0>;
100100
max-brightness = <255>;

‎arch/arm/boot/dts/at91-kizboxmini-common.dtsi‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -54,25 +54,25 @@
5454
};
5555
};
5656

57-
leds: pwm_leds {
57+
leds: led-controller-1 {
5858
compatible = "pwm-leds";
5959

60-
led_blue: pwm_blue {
60+
led_blue: led-1 {
6161
label = "pwm:blue:user";
6262
pwms = <&pwm0 2 10000000 0>;
6363
max-brightness = <255>;
6464
linux,default-trigger = "none";
6565
status = "disabled";
6666
};
6767

68-
led_green: pwm_green {
68+
led_green: led-2 {
6969
label = "pwm:green:user";
7070
pwms = <&pwm0 0 10000000 0>;
7171
max-brightness = <255>;
7272
linux,default-trigger = "default-on";
7373
};
7474

75-
led_red: pwm_red {
75+
led_red: led-3 {
7676
label = "pwm:red:user";
7777
pwms = <&pwm0 1 10000000 0>;
7878
max-brightness = <255>;

‎arch/arm/boot/dts/at91sam9m10g45ek.dts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -315,27 +315,27 @@
315315
};
316316
};
317317

318-
leds {
318+
led-controller-1 {
319319
compatible = "gpio-leds";
320320

321-
d8 {
321+
led-1 {
322322
label = "d8";
323323
gpios = <&pioD 30 GPIO_ACTIVE_HIGH>;
324324
linux,default-trigger = "heartbeat";
325325
};
326326
};
327327

328-
pwmleds {
328+
led-controller-2 {
329329
compatible = "pwm-leds";
330330

331-
d6 {
331+
led-2 {
332332
label = "d6";
333333
pwms = <&pwm0 3 5000 PWM_POLARITY_INVERTED>;
334334
max-brightness = <255>;
335335
linux,default-trigger = "nand-disk";
336336
};
337337

338-
d7 {
338+
led-3 {
339339
label = "d7";
340340
pwms = <&pwm0 1 5000 PWM_POLARITY_INVERTED>;
341341
max-brightness = <255>;

‎arch/arm/boot/dts/at91sam9rlek.dts‎

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -218,26 +218,26 @@
218218
};
219219
};
220220

221-
pwmleds {
221+
led-controller-1 {
222222
compatible = "pwm-leds";
223223

224-
ds1 {
224+
led-1 {
225225
label = "ds1";
226226
pwms = <&pwm0 1 5000 PWM_POLARITY_INVERTED>;
227227
max-brightness = <255>;
228228
};
229229

230-
ds2 {
230+
led-2 {
231231
label = "ds2";
232232
pwms = <&pwm0 2 5000 PWM_POLARITY_INVERTED>;
233233
max-brightness = <255>;
234234
};
235235
};
236236

237-
leds {
237+
led-controller-2 {
238238
compatible = "gpio-leds";
239239

240-
ds3 {
240+
led-3 {
241241
label = "ds3";
242242
gpios = <&pioD 14 GPIO_ACTIVE_HIGH>;
243243
linux,default-trigger = "heartbeat";

0 commit comments

Comments
 (0)