Skip to content

Commit 50317fc

Browse files
congwangdavem330
authored andcommitted
net_sched: avoid matching qdisc with zero handle
Davide found the following script triggers a NULL pointer dereference: ip l a name eth0 type dummy tc q a dev eth0 parent :1 handle 1: htb This is because for a freshly created netdevice noop_qdisc is attached and when passing 'parent :1', kernel actually tries to match the major handle which is 0 and noop_qdisc has handle 0 so is matched by mistake. Commit 69012ae tries to fix a similar bug but still misses this case. Handle 0 is not a valid one, should be just skipped. In fact, kernel uses it as TC_H_UNSPEC. Fixes: 69012ae ("net: sched: fix handling of singleton qdiscs with qdisc_hash") Fixes: 59cc1f6 ("net: sched:convert qdisc linked list to hashtable") Reported-by: Davide Caratti <dcaratti@redhat.com> Cc: Jiri Kosina <jkosina@suse.cz> Cc: Eric Dumazet <edumazet@google.com> Cc: Jamal Hadi Salim <jhs@mojatatu.com> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent d04adf1 commit 50317fc

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

net/sched/sch_api.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -301,6 +301,8 @@ struct Qdisc *qdisc_lookup(struct net_device *dev, u32 handle)
301301
{
302302
struct Qdisc *q;
303303

304+
if (!handle)
305+
return NULL;
304306
q = qdisc_match_from_root(dev->qdisc, handle);
305307
if (q)
306308
goto out;

0 commit comments

Comments
 (0)