Skip to content

Commit 4f6e709

Browse files
fugangduangregkh
authored andcommitted
net: fec_ptp: add clock rate zero check
commit cb3cefe upstream. Add clock rate zero check to fix coverity issue of "divide by 0". Fixes: commit 85bd179 ("net: fec: fix spin_lock dead lock") Signed-off-by: Fugang Duan <fugang.duan@nxp.com> Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 1af3a8e commit 4f6e709

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

drivers/net/ethernet/freescale/fec_ptp.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -602,6 +602,10 @@ void fec_ptp_init(struct platform_device *pdev, int irq_idx)
602602
fep->ptp_caps.enable = fec_ptp_enable;
603603

604604
fep->cycle_speed = clk_get_rate(fep->clk_ptp);
605+
if (!fep->cycle_speed) {
606+
fep->cycle_speed = NSEC_PER_SEC;
607+
dev_err(&fep->pdev->dev, "clk_ptp clock rate is zero\n");
608+
}
605609
fep->ptp_inc = NSEC_PER_SEC / fep->cycle_speed;
606610

607611
spin_lock_init(&fep->tmreg_lock);

0 commit comments

Comments
 (0)