Skip to content

Commit 4cb1935

Browse files
committed
device-dax: fail all private mapping attempts
The device-dax implementation originally tried to be tricky and allow private read-only mappings, but in the process allowed writable MAP_PRIVATE + MAP_NORESERVE mappings. For simplicity and predictability just fail all private mapping attempts since device-dax memory is statically allocated and will never support overcommit. Cc: <stable@vger.kernel.org> Cc: Dave Hansen <dave.hansen@linux.intel.com> Fixes: dee4107 ("/dev/dax, core: file operations and dax-mmap") Reported-by: Pawel Lebioda <pawel.lebioda@intel.com> Signed-off-by: Dan Williams <dan.j.williams@intel.com>
1 parent 6a84fb4 commit 4cb1935

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

drivers/dax/dax.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -270,8 +270,8 @@ static int check_vma(struct dax_dev *dax_dev, struct vm_area_struct *vma,
270270
if (!dax_dev->alive)
271271
return -ENXIO;
272272

273-
/* prevent private / writable mappings from being established */
274-
if ((vma->vm_flags & (VM_NORESERVE|VM_SHARED|VM_WRITE)) == VM_WRITE) {
273+
/* prevent private mappings from being established */
274+
if ((vma->vm_flags & VM_SHARED) != VM_SHARED) {
275275
dev_info(dev, "%s: %s: fail, attempted private mapping\n",
276276
current->comm, func);
277277
return -EINVAL;

0 commit comments

Comments
 (0)