Skip to content

Commit 4739df6

Browse files
himanshujha199640davem330
authored andcommitted
qed: remove unnecessary call to memset
call to memset to assign 0 value immediately after allocating memory with kzalloc is unnecesaary as kzalloc allocates the memory filled with 0 value. Semantic patch used to resolve this issue: @@ expression e,e2; constant c; statement S; @@ e = kzalloc(e2, c); if(e == NULL) S - memset(e, 0, e2); Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com> Signed-off-by: Himanshu Jha <himanshujha199640@gmail.com> Acked-by: Sudarsana Kalluru <sudarsana.kalluru@cavium.com> Signed-off-by: David S. Miller <davem@davemloft.net>
1 parent 23f4822 commit 4739df6

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

drivers/net/ethernet/qlogic/qed/qed_dcbx.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1244,7 +1244,6 @@ int qed_dcbx_get_config_params(struct qed_hwfn *p_hwfn,
12441244
if (!dcbx_info)
12451245
return -ENOMEM;
12461246

1247-
memset(dcbx_info, 0, sizeof(*dcbx_info));
12481247
rc = qed_dcbx_query_params(p_hwfn, dcbx_info, QED_DCBX_OPERATIONAL_MIB);
12491248
if (rc) {
12501249
kfree(dcbx_info);

0 commit comments

Comments
 (0)