Skip to content

Commit 4703593

Browse files
plbossartgregkh
authored andcommitted
soundwire: fix regmap dependencies and align with other serial links
[ Upstream commit 8676b3c ] The existing code has a mixed select/depend usage which makes no sense. config SOUNDWIRE_BUS tristate select REGMAP_SOUNDWIRE config REGMAP_SOUNDWIRE tristate depends on SOUNDWIRE_BUS Let's remove one layer of Kconfig definitions and align with the solutions used by all other serial links. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com> Link: https://lore.kernel.org/r/20190718230215.18675-1-pierre-louis.bossart@linux.intel.com Signed-off-by: Vinod Koul <vkoul@kernel.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 322753c commit 4703593

3 files changed

Lines changed: 3 additions & 8 deletions

File tree

drivers/base/regmap/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ config REGMAP_IRQ
4444

4545
config REGMAP_SOUNDWIRE
4646
tristate
47-
depends on SOUNDWIRE_BUS
47+
depends on SOUNDWIRE
4848

4949
config REGMAP_SCCB
5050
tristate

drivers/soundwire/Kconfig

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
#
44

55
menuconfig SOUNDWIRE
6-
bool "SoundWire support"
6+
tristate "SoundWire support"
77
help
88
SoundWire is a 2-Pin interface with data and clock line ratified
99
by the MIPI Alliance. SoundWire is used for transporting data
@@ -16,17 +16,12 @@ if SOUNDWIRE
1616

1717
comment "SoundWire Devices"
1818

19-
config SOUNDWIRE_BUS
20-
tristate
21-
select REGMAP_SOUNDWIRE
22-
2319
config SOUNDWIRE_CADENCE
2420
tristate
2521

2622
config SOUNDWIRE_INTEL
2723
tristate "Intel SoundWire Master driver"
2824
select SOUNDWIRE_CADENCE
29-
select SOUNDWIRE_BUS
3025
depends on X86 && ACPI && SND_SOC
3126
---help---
3227
SoundWire Intel Master driver.

drivers/soundwire/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
#Bus Objs
66
soundwire-bus-objs := bus_type.o bus.o slave.o mipi_disco.o stream.o
7-
obj-$(CONFIG_SOUNDWIRE_BUS) += soundwire-bus.o
7+
obj-$(CONFIG_SOUNDWIRE) += soundwire-bus.o
88

99
#Cadence Objs
1010
soundwire-cadence-objs := cadence_master.o

0 commit comments

Comments
 (0)