Skip to content

Commit 41ec793

Browse files
committed
Merge branch 'fixes' of git://git.armlinux.org.uk/~rmk/linux-arm
Pull ARM fixes from Russell King: "A fix for a regression on ARMv4T CPUs, and wiring up the new pkey syscalls for ARM" * 'fixes' of git://git.armlinux.org.uk/~rmk/linux-arm: ARM: wire up new pkey syscalls ARM: fix oops when using older ARMv4T CPUs
2 parents 04ed7d9 + 6127d12 commit 41ec793

4 files changed

Lines changed: 31 additions & 11 deletions

File tree

arch/arm/include/asm/unistd.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
* This may need to be greater than __NR_last_syscall+1 in order to
2020
* account for the padding in the syscall table
2121
*/
22-
#define __NR_syscalls (396)
22+
#define __NR_syscalls (400)
2323

2424
#define __ARCH_WANT_STAT64
2525
#define __ARCH_WANT_SYS_GETHOSTNAME

arch/arm/include/uapi/asm/unistd.h

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -420,6 +420,9 @@
420420
#define __NR_copy_file_range (__NR_SYSCALL_BASE+391)
421421
#define __NR_preadv2 (__NR_SYSCALL_BASE+392)
422422
#define __NR_pwritev2 (__NR_SYSCALL_BASE+393)
423+
#define __NR_pkey_mprotect (__NR_SYSCALL_BASE+394)
424+
#define __NR_pkey_alloc (__NR_SYSCALL_BASE+395)
425+
#define __NR_pkey_free (__NR_SYSCALL_BASE+396)
423426

424427
/*
425428
* The following SWIs are ARM private.

arch/arm/kernel/calls.S

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -403,6 +403,9 @@
403403
CALL(sys_copy_file_range)
404404
CALL(sys_preadv2)
405405
CALL(sys_pwritev2)
406+
CALL(sys_pkey_mprotect)
407+
/* 395 */ CALL(sys_pkey_alloc)
408+
CALL(sys_pkey_free)
406409
#ifndef syscalls_counted
407410
.equ syscalls_padding, ((NR_syscalls + 3) & ~3) - NR_syscalls
408411
#define syscalls_counted

arch/arm/mm/abort-lv4t.S

Lines changed: 24 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* : r4 = aborted context pc
88
* : r5 = aborted context psr
99
*
10-
* Returns : r4-r5, r10-r11, r13 preserved
10+
* Returns : r4-r5, r9-r11, r13 preserved
1111
*
1212
* Purpose : obtain information about current aborted instruction.
1313
* Note: we read user space. This means we might cause a data
@@ -48,7 +48,10 @@ ENTRY(v4t_late_abort)
4848
/* c */ b do_DataAbort @ ldc rd, [rn], #m @ Same as ldr rd, [rn], #m
4949
/* d */ b do_DataAbort @ ldc rd, [rn, #m]
5050
/* e */ b .data_unknown
51-
/* f */
51+
/* f */ b .data_unknown
52+
53+
.data_unknown_r9:
54+
ldr r9, [sp], #4
5255
.data_unknown: @ Part of jumptable
5356
mov r0, r4
5457
mov r1, r8
@@ -57,6 +60,7 @@ ENTRY(v4t_late_abort)
5760
.data_arm_ldmstm:
5861
tst r8, #1 << 21 @ check writeback bit
5962
beq do_DataAbort @ no writeback -> no fixup
63+
str r9, [sp, #-4]!
6064
mov r7, #0x11
6165
orr r7, r7, #0x1100
6266
and r6, r8, r7
@@ -75,12 +79,14 @@ ENTRY(v4t_late_abort)
7579
subne r7, r7, r6, lsl #2 @ Undo increment
7680
addeq r7, r7, r6, lsl #2 @ Undo decrement
7781
str r7, [r2, r9, lsr #14] @ Put register 'Rn'
82+
ldr r9, [sp], #4
7883
b do_DataAbort
7984

8085
.data_arm_lateldrhpre:
8186
tst r8, #1 << 21 @ Check writeback bit
8287
beq do_DataAbort @ No writeback -> no fixup
8388
.data_arm_lateldrhpost:
89+
str r9, [sp, #-4]!
8490
and r9, r8, #0x00f @ get Rm / low nibble of immediate value
8591
tst r8, #1 << 22 @ if (immediate offset)
8692
andne r6, r8, #0xf00 @ { immediate high nibble
@@ -93,6 +99,7 @@ ENTRY(v4t_late_abort)
9399
subne r7, r7, r6 @ Undo incrmenet
94100
addeq r7, r7, r6 @ Undo decrement
95101
str r7, [r2, r9, lsr #14] @ Put register 'Rn'
102+
ldr r9, [sp], #4
96103
b do_DataAbort
97104

98105
.data_arm_lateldrpreconst:
@@ -101,12 +108,14 @@ ENTRY(v4t_late_abort)
101108
.data_arm_lateldrpostconst:
102109
movs r6, r8, lsl #20 @ Get offset
103110
beq do_DataAbort @ zero -> no fixup
111+
str r9, [sp, #-4]!
104112
and r9, r8, #15 << 16 @ Extract 'n' from instruction
105113
ldr r7, [r2, r9, lsr #14] @ Get register 'Rn'
106114
tst r8, #1 << 23 @ Check U bit
107115
subne r7, r7, r6, lsr #20 @ Undo increment
108116
addeq r7, r7, r6, lsr #20 @ Undo decrement
109117
str r7, [r2, r9, lsr #14] @ Put register 'Rn'
118+
ldr r9, [sp], #4
110119
b do_DataAbort
111120

112121
.data_arm_lateldrprereg:
@@ -115,6 +124,7 @@ ENTRY(v4t_late_abort)
115124
.data_arm_lateldrpostreg:
116125
and r7, r8, #15 @ Extract 'm' from instruction
117126
ldr r6, [r2, r7, lsl #2] @ Get register 'Rm'
127+
str r9, [sp, #-4]!
118128
mov r9, r8, lsr #7 @ get shift count
119129
ands r9, r9, #31
120130
and r7, r8, #0x70 @ get shift type
@@ -126,33 +136,33 @@ ENTRY(v4t_late_abort)
126136
b .data_arm_apply_r6_and_rn
127137
b .data_arm_apply_r6_and_rn @ 1: LSL #0
128138
nop
129-
b .data_unknown @ 2: MUL?
139+
b .data_unknown_r9 @ 2: MUL?
130140
nop
131-
b .data_unknown @ 3: MUL?
141+
b .data_unknown_r9 @ 3: MUL?
132142
nop
133143
mov r6, r6, lsr r9 @ 4: LSR #!0
134144
b .data_arm_apply_r6_and_rn
135145
mov r6, r6, lsr #32 @ 5: LSR #32
136146
b .data_arm_apply_r6_and_rn
137-
b .data_unknown @ 6: MUL?
147+
b .data_unknown_r9 @ 6: MUL?
138148
nop
139-
b .data_unknown @ 7: MUL?
149+
b .data_unknown_r9 @ 7: MUL?
140150
nop
141151
mov r6, r6, asr r9 @ 8: ASR #!0
142152
b .data_arm_apply_r6_and_rn
143153
mov r6, r6, asr #32 @ 9: ASR #32
144154
b .data_arm_apply_r6_and_rn
145-
b .data_unknown @ A: MUL?
155+
b .data_unknown_r9 @ A: MUL?
146156
nop
147-
b .data_unknown @ B: MUL?
157+
b .data_unknown_r9 @ B: MUL?
148158
nop
149159
mov r6, r6, ror r9 @ C: ROR #!0
150160
b .data_arm_apply_r6_and_rn
151161
mov r6, r6, rrx @ D: RRX
152162
b .data_arm_apply_r6_and_rn
153-
b .data_unknown @ E: MUL?
163+
b .data_unknown_r9 @ E: MUL?
154164
nop
155-
b .data_unknown @ F: MUL?
165+
b .data_unknown_r9 @ F: MUL?
156166

157167
.data_thumb_abort:
158168
ldrh r8, [r4] @ read instruction
@@ -190,6 +200,7 @@ ENTRY(v4t_late_abort)
190200
.data_thumb_pushpop:
191201
tst r8, #1 << 10
192202
beq .data_unknown
203+
str r9, [sp, #-4]!
193204
and r6, r8, #0x55 @ hweight8(r8) + R bit
194205
and r9, r8, #0xaa
195206
add r6, r6, r9, lsr #1
@@ -204,9 +215,11 @@ ENTRY(v4t_late_abort)
204215
addeq r7, r7, r6, lsl #2 @ increment SP if PUSH
205216
subne r7, r7, r6, lsl #2 @ decrement SP if POP
206217
str r7, [r2, #13 << 2]
218+
ldr r9, [sp], #4
207219
b do_DataAbort
208220

209221
.data_thumb_ldmstm:
222+
str r9, [sp, #-4]!
210223
and r6, r8, #0x55 @ hweight8(r8)
211224
and r9, r8, #0xaa
212225
add r6, r6, r9, lsr #1
@@ -219,4 +232,5 @@ ENTRY(v4t_late_abort)
219232
and r6, r6, #15 @ number of regs to transfer
220233
sub r7, r7, r6, lsl #2 @ always decrement
221234
str r7, [r2, r9, lsr #6]
235+
ldr r9, [sp], #4
222236
b do_DataAbort

0 commit comments

Comments
 (0)