Skip to content

Commit 414bd73

Browse files
joelagnelgregkh
authored andcommitted
debugobjects: Make stack check warning more informative
commit fc91a3c upstream. While debugging an issue debugobject tracking warned about an annotation issue of an object on stack. It turned out that the issue was due to the object in concern being on a different stack which was due to another issue. Thomas suggested to print the pointers and the location of the stack for the currently running task. This helped to figure out that the object was on the wrong stack. As this is general useful information for debugging similar issues, make the error message more informative by printing the pointers. [ tglx: Massaged changelog ] Signed-off-by: Joel Fernandes (Google) <joel@joelfernandes.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Acked-by: Waiman Long <longman@redhat.com> Acked-by: Yang Shi <yang.shi@linux.alibaba.com> Cc: kernel-team@android.com Cc: Arnd Bergmann <arnd@arndb.de> Cc: astrachan@google.com Link: https://lkml.kernel.org/r/20180723212531.202328-1-joel@joelfernandes.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 33d2811 commit 414bd73

1 file changed

Lines changed: 5 additions & 2 deletions

File tree

lib/debugobjects.c

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -294,9 +294,12 @@ static void debug_object_is_on_stack(void *addr, int onstack)
294294

295295
limit++;
296296
if (is_on_stack)
297-
pr_warn("object is on stack, but not annotated\n");
297+
pr_warn("object %p is on stack %p, but NOT annotated.\n", addr,
298+
task_stack_page(current));
298299
else
299-
pr_warn("object is not on stack, but annotated\n");
300+
pr_warn("object %p is NOT on stack %p, but annotated.\n", addr,
301+
task_stack_page(current));
302+
300303
WARN_ON(1);
301304
}
302305

0 commit comments

Comments
 (0)