Skip to content

Commit 3dc006d

Browse files
Li Dongyanggregkh
authored andcommitted
ext4: don't mark mmp buffer head dirty
commit fe18d64 upstream. Marking mmp bh dirty before writing it will make writeback pick up mmp block later and submit a write, we don't want the duplicate write as kmmpd thread should have full control of reading and writing the mmp block. Another reason is we will also have random I/O error on the writeback request when blk integrity is enabled, because kmmpd could modify the content of the mmp block(e.g. setting new seq and time) while the mmp block is under I/O requested by writeback. Signed-off-by: Li Dongyang <dongyangli@ddn.com> Signed-off-by: Theodore Ts'o <tytso@mit.edu> Reviewed-by: Andreas Dilger <adilger@dilger.ca> Cc: stable@vger.kernel.org Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent ba48e66 commit 3dc006d

1 file changed

Lines changed: 0 additions & 1 deletion

File tree

fs/ext4/mmp.c

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,6 @@ static int write_mmp_block(struct super_block *sb, struct buffer_head *bh)
4949
*/
5050
sb_start_write(sb);
5151
ext4_mmp_csum_set(sb, mmp);
52-
mark_buffer_dirty(bh);
5352
lock_buffer(bh);
5453
bh->b_end_io = end_buffer_write_sync;
5554
get_bh(bh);

0 commit comments

Comments
 (0)