Skip to content

Commit 35f9ff4

Browse files
lostjefflegregkh
authored andcommitted
netfs: fix parameter of cleanup()
commit 3cfef1b upstream. The order of these two parameters is just reversed. gcc didn't warn on that, probably because 'void *' can be converted from or to other pointer types without warning. Cc: stable@vger.kernel.org Fixes: 3d3c950 ("netfs: Provide readahead and readpage netfs helpers") Fixes: e1b1240 ("netfs: Add write_begin helper") Signed-off-by: Jeffle Xu <jefflexu@linux.alibaba.com> Signed-off-by: David Howells <dhowells@redhat.com> Reviewed-by: Jeff Layton <jlayton@redhat.com> Link: https://lore.kernel.org/r/20211207031449.100510-1-jefflexu@linux.alibaba.com/ # v1 Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent a8a9d75 commit 35f9ff4

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

fs/netfs/read_helper.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -958,7 +958,7 @@ int netfs_readpage(struct file *file,
958958
rreq = netfs_alloc_read_request(ops, netfs_priv, file);
959959
if (!rreq) {
960960
if (netfs_priv)
961-
ops->cleanup(netfs_priv, page_file_mapping(page));
961+
ops->cleanup(page_file_mapping(page), netfs_priv);
962962
unlock_page(page);
963963
return -ENOMEM;
964964
}
@@ -1185,7 +1185,7 @@ int netfs_write_begin(struct file *file, struct address_space *mapping,
11851185
goto error;
11861186
have_page_no_wait:
11871187
if (netfs_priv)
1188-
ops->cleanup(netfs_priv, mapping);
1188+
ops->cleanup(mapping, netfs_priv);
11891189
*_page = page;
11901190
_leave(" = 0");
11911191
return 0;
@@ -1196,7 +1196,7 @@ int netfs_write_begin(struct file *file, struct address_space *mapping,
11961196
unlock_page(page);
11971197
put_page(page);
11981198
if (netfs_priv)
1199-
ops->cleanup(netfs_priv, mapping);
1199+
ops->cleanup(mapping, netfs_priv);
12001200
_leave(" = %d", ret);
12011201
return ret;
12021202
}

0 commit comments

Comments
 (0)