Skip to content

Commit 352d98f

Browse files
author
Codrin Ciubotariu
committed
ARM: at91/dt: sama5d: Configure I2C SCL gpio as open drain
The SCL gpio pin used by I2C bus for recovery needs to be configured as open drain. Fixes: 0d60ac7 ("ARM: at91/dt: sama5d2: add i2c gpio pinctrl") Fixes: 5dc989c ("ARM: at91/dt: sama5d3: add i2c gpio pinctrl") Fixes: 3b5c040 ("ARM: at91/dt: sama5d4: add i2c gpio pinctrl") Signed-off-by: Codrin Ciubotariu <codrin.ciubotariu@microchip.com> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
1 parent fa7a136 commit 352d98f

4 files changed

Lines changed: 13 additions & 13 deletions

File tree

‎arch/arm/boot/dts/at91-sama5d2_ptc_ek.dts‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@
183183
pinctrl-0 = <&pinctrl_i2c0_default>;
184184
pinctrl-1 = <&pinctrl_i2c0_gpio>;
185185
sda-gpios = <&pioA PIN_PD21 GPIO_ACTIVE_HIGH>;
186-
scl-gpios = <&pioA PIN_PD22 GPIO_ACTIVE_HIGH>;
186+
scl-gpios = <&pioA PIN_PD22 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
187187
status = "okay";
188188
};
189189

@@ -204,7 +204,7 @@
204204
pinctrl-0 = <&pinctrl_flx0_default>;
205205
pinctrl-1 = <&pinctrl_flx0_gpio>;
206206
sda-gpios = <&pioA PIN_PB28 GPIO_ACTIVE_HIGH>;
207-
scl-gpios = <&pioA PIN_PB29 GPIO_ACTIVE_HIGH>;
207+
scl-gpios = <&pioA PIN_PB29 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
208208
atmel,fifo-size = <16>;
209209
status = "okay";
210210
};
@@ -235,7 +235,7 @@
235235
pinctrl-0 = <&pinctrl_i2c1_default>;
236236
pinctrl-1 = <&pinctrl_i2c1_gpio>;
237237
sda-gpios = <&pioA PIN_PC6 GPIO_ACTIVE_HIGH>;
238-
scl-gpios = <&pioA PIN_PC7 GPIO_ACTIVE_HIGH>;
238+
scl-gpios = <&pioA PIN_PC7 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
239239
status = "okay";
240240

241241
at24@50 {

‎arch/arm/boot/dts/at91-sama5d2_xplained.dts‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@
192192
pinctrl-0 = <&pinctrl_i2c0_default>;
193193
pinctrl-1 = <&pinctrl_i2c0_gpio>;
194194
sda-gpios = <&pioA PIN_PD21 GPIO_ACTIVE_HIGH>;
195-
scl-gpios = <&pioA PIN_PD22 GPIO_ACTIVE_HIGH>;
195+
scl-gpios = <&pioA PIN_PD22 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
196196
i2c-sda-hold-time-ns = <350>;
197197
status = "okay";
198198

@@ -358,7 +358,7 @@
358358
pinctrl-0 = <&pinctrl_flx0_default>;
359359
pinctrl-1 = <&pinctrl_i2c2_gpio>;
360360
sda-gpios = <&pioA PIN_PB28 GPIO_ACTIVE_HIGH>;
361-
scl-gpios = <&pioA PIN_PB29 GPIO_ACTIVE_HIGH>;
361+
scl-gpios = <&pioA PIN_PB29 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
362362
i2c-sda-hold-time-ns = <350>;
363363
i2c-analog-filter;
364364
i2c-digital-filter;
@@ -419,7 +419,7 @@
419419
pinctrl-0 = <&pinctrl_flx4_default>;
420420
pinctrl-1 = <&pinctrl_flx4_gpio>;
421421
sda-gpios = <&pioA PIN_PD12 GPIO_ACTIVE_HIGH>;
422-
scl-gpios = <&pioA PIN_PD13 GPIO_ACTIVE_HIGH>;
422+
scl-gpios = <&pioA PIN_PD13 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
423423
atmel,fifo-size = <16>;
424424
i2c-analog-filter;
425425
i2c-digital-filter;
@@ -437,7 +437,7 @@
437437
i2c-digital-filter-width-ns = <35>;
438438
pinctrl-1 = <&pinctrl_i2c1_gpio>;
439439
sda-gpios = <&pioA PIN_PD4 GPIO_ACTIVE_HIGH>;
440-
scl-gpios = <&pioA PIN_PD5 GPIO_ACTIVE_HIGH>;
440+
scl-gpios = <&pioA PIN_PD5 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
441441
status = "okay";
442442

443443
at24@54 {

‎arch/arm/boot/dts/sama5d3.dtsi‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -163,7 +163,7 @@
163163
pinctrl-0 = <&pinctrl_i2c0>;
164164
pinctrl-1 = <&pinctrl_i2c0_gpio>;
165165
sda-gpios = <&pioA 30 GPIO_ACTIVE_HIGH>;
166-
scl-gpios = <&pioA 31 GPIO_ACTIVE_HIGH>;
166+
scl-gpios = <&pioA 31 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
167167
#address-cells = <1>;
168168
#size-cells = <0>;
169169
clocks = <&twi0_clk>;
@@ -181,7 +181,7 @@
181181
pinctrl-0 = <&pinctrl_i2c1>;
182182
pinctrl-1 = <&pinctrl_i2c1_gpio>;
183183
sda-gpios = <&pioC 26 GPIO_ACTIVE_HIGH>;
184-
scl-gpios = <&pioC 27 GPIO_ACTIVE_HIGH>;
184+
scl-gpios = <&pioC 27 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
185185
#address-cells = <1>;
186186
#size-cells = <0>;
187187
clocks = <&twi1_clk>;
@@ -367,7 +367,7 @@
367367
pinctrl-0 = <&pinctrl_i2c2>;
368368
pinctrl-1 = <&pinctrl_i2c2_gpio>;
369369
sda-gpios = <&pioA 18 GPIO_ACTIVE_HIGH>;
370-
scl-gpios = <&pioA 19 GPIO_ACTIVE_HIGH>;
370+
scl-gpios = <&pioA 19 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
371371
#address-cells = <1>;
372372
#size-cells = <0>;
373373
clocks = <&twi2_clk>;

‎arch/arm/boot/dts/sama5d4.dtsi‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -471,7 +471,7 @@
471471
pinctrl-0 = <&pinctrl_i2c0>;
472472
pinctrl-1 = <&pinctrl_i2c0_gpio>;
473473
sda-gpios = <&pioA 30 GPIO_ACTIVE_HIGH>;
474-
scl-gpios = <&pioA 31 GPIO_ACTIVE_HIGH>;
474+
scl-gpios = <&pioA 31 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
475475
#address-cells = <1>;
476476
#size-cells = <0>;
477477
clocks = <&pmc PMC_TYPE_PERIPHERAL 32>;
@@ -493,7 +493,7 @@
493493
pinctrl-0 = <&pinctrl_i2c1>;
494494
pinctrl-1 = <&pinctrl_i2c1_gpio>;
495495
sda-gpios = <&pioE 29 GPIO_ACTIVE_HIGH>;
496-
scl-gpios = <&pioE 30 GPIO_ACTIVE_HIGH>;
496+
scl-gpios = <&pioE 30 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
497497
#address-cells = <1>;
498498
#size-cells = <0>;
499499
clocks = <&pmc PMC_TYPE_PERIPHERAL 33>;
@@ -538,7 +538,7 @@
538538
pinctrl-0 = <&pinctrl_i2c2>;
539539
pinctrl-1 = <&pinctrl_i2c2_gpio>;
540540
sda-gpios = <&pioB 29 GPIO_ACTIVE_HIGH>;
541-
scl-gpios = <&pioB 30 GPIO_ACTIVE_HIGH>;
541+
scl-gpios = <&pioB 30 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
542542
#address-cells = <1>;
543543
#size-cells = <0>;
544544
clocks = <&pmc PMC_TYPE_PERIPHERAL 34>;

0 commit comments

Comments
 (0)