Skip to content

Commit 33cabe0

Browse files
stonezdmgregkh
authored andcommitted
tty: n_gsm: fix sleep-in-atomic-context bug in gsm_control_send
[ Upstream commit 7b7dfe4 ] The function gsm_dlci_t1() is a timer handler that runs in an atomic context, but it calls "kzalloc(..., GFP_KERNEL)" that may sleep. As a result, the sleep-in-atomic-context bug will happen. The process is shown below: gsm_dlci_t1() gsm_dlci_open() gsm_modem_update() gsm_modem_upd_via_msc() gsm_control_send() kzalloc(sizeof(.., GFP_KERNEL) //may sleep This patch changes the gfp_t parameter of kzalloc() from GFP_KERNEL to GFP_ATOMIC in order to mitigate the bug. Fixes: e1eaea4 ("tty: n_gsm line discipline") Signed-off-by: Duoming Zhou <duoming@zju.edu.cn> Link: https://lore.kernel.org/r/20221002040709.27849-1-duoming@zju.edu.cn Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent ae22294 commit 33cabe0

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/tty/n_gsm.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1577,7 +1577,7 @@ static struct gsm_control *gsm_control_send(struct gsm_mux *gsm,
15771577
unsigned int command, u8 *data, int clen)
15781578
{
15791579
struct gsm_control *ctrl = kzalloc(sizeof(struct gsm_control),
1580-
GFP_KERNEL);
1580+
GFP_ATOMIC);
15811581
unsigned long flags;
15821582
if (ctrl == NULL)
15831583
return NULL;

0 commit comments

Comments
 (0)