Skip to content

Commit 330c611

Browse files
sjp38gregkh
authored andcommitted
mm/damon/dbgfs: protect targets destructions with kdamond_lock
commit 3479641 upstream. DAMON debugfs interface iterates current monitoring targets in 'dbgfs_target_ids_read()' while holding the corresponding 'kdamond_lock'. However, it also destructs the monitoring targets in 'dbgfs_before_terminate()' without holding the lock. This can result in a use_after_free bug. This commit avoids the race by protecting the destruction with the corresponding 'kdamond_lock'. Link: https://lkml.kernel.org/r/20211221094447.2241-1-sj@kernel.org Reported-by: Sangwoo Bae <sangwoob@amazon.com> Fixes: 4bc0595 ("mm/damon: implement a debugfs-based user space interface") Signed-off-by: SeongJae Park <sj@kernel.org> Cc: <stable@vger.kernel.org> [5.15.x] Signed-off-by: Andrew Morton <akpm@linux-foundation.org> Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent c691e75 commit 330c611

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

mm/damon/dbgfs.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -309,10 +309,12 @@ static int dbgfs_before_terminate(struct damon_ctx *ctx)
309309
if (!targetid_is_pid(ctx))
310310
return 0;
311311

312+
mutex_lock(&ctx->kdamond_lock);
312313
damon_for_each_target_safe(t, next, ctx) {
313314
put_pid((struct pid *)t->id);
314315
damon_destroy_target(t);
315316
}
317+
mutex_unlock(&ctx->kdamond_lock);
316318
return 0;
317319
}
318320

0 commit comments

Comments
 (0)