Skip to content

Commit 2c7de6d

Browse files
johnstultz-workgregkh
authored andcommitted
selftest: timers: Tweak raw_skew to SKIP when ADJ_OFFSET/other clock adjustments are in progress
[ Upstream commit 1416270 ] In the past we've warned when ADJ_OFFSET was in progress, usually caused by ntpd or some other time adjusting daemon running in non steady sate, which can cause the skew calculations to be incorrect. Thus, this patch checks to see if the clock was being adjusted when we fail so that we don't cause false negatives. Cc: Thomas Gleixner <tglx@linutronix.de> Cc: Ingo Molnar <mingo@kernel.org> Cc: Miroslav Lichvar <mlichvar@redhat.com> Cc: Richard Cochran <richardcochran@gmail.com> Cc: Prarit Bhargava <prarit@redhat.com> Cc: Stephen Boyd <sboyd@kernel.org> Cc: Shuah Khan <shuah@kernel.org> Cc: linux-kselftest@vger.kernel.org Suggested-by: Miroslav Lichvar <mlichvar@redhat.com> Signed-off-by: John Stultz <john.stultz@linaro.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 7a5096c commit 2c7de6d

1 file changed

Lines changed: 5 additions & 0 deletions

File tree

tools/testing/selftests/timers/raw_skew.c

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,11 @@ int main(int argv, char **argc)
134134
printf(" %lld.%i(act)", ppm/1000, abs((int)(ppm%1000)));
135135

136136
if (llabs(eppm - ppm) > 1000) {
137+
if (tx1.offset || tx2.offset ||
138+
tx1.freq != tx2.freq || tx1.tick != tx2.tick) {
139+
printf(" [SKIP]\n");
140+
return ksft_exit_skip("The clock was adjusted externally. Shutdown NTPd or other time sync daemons\n");
141+
}
137142
printf(" [FAILED]\n");
138143
return ksft_exit_fail();
139144
}

0 commit comments

Comments
 (0)