Skip to content

Commit 2724b72

Browse files
mqqcgregkh
authored andcommitted
ACPI / x86: Work around broken XSDT on Advantech DAC-BJ01 board
commit e702196 upstream. On this board the ACPI RSDP structure points to both a RSDT and an XSDT, but the XSDT points to a truncated FADT. This causes all sorts of trouble and usually a complete failure to boot after the following error occurs: ACPI Error: Unsupported address space: 0x20 (*/hwregs-*) ACPI Error: AE_SUPPORT, Unable to initialize fixed events (*/evevent-*) ACPI: Unable to start ACPI Interpreter This leaves the ACPI implementation in such a broken state that subsequent kernel subsystem initialisations go wrong, resulting in among others mismapped PCI memory, SATA and USB enumeration failures, and freezes. As this is an older embedded platform that will likely never see any BIOS updates to address this issue and its default shipping OS only complies to ACPI 1.0, work around this by forcing `acpi=rsdt`. This patch, applied on top of Linux 5.10.102, was confirmed on real hardware to fix the issue. Signed-off-by: Mark Cilissen <mark@yotsuba.nl> Cc: All applicable <stable@vger.kernel.org> Reviewed-by: Hans de Goede <hdegoede@redhat.com> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 2c74374 commit 2724b72

1 file changed

Lines changed: 24 additions & 0 deletions

File tree

arch/x86/kernel/acpi/boot.c

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1340,6 +1340,17 @@ static int __init disable_acpi_pci(const struct dmi_system_id *d)
13401340
return 0;
13411341
}
13421342

1343+
static int __init disable_acpi_xsdt(const struct dmi_system_id *d)
1344+
{
1345+
if (!acpi_force) {
1346+
pr_notice("%s detected: force use of acpi=rsdt\n", d->ident);
1347+
acpi_gbl_do_not_use_xsdt = TRUE;
1348+
} else {
1349+
pr_notice("Warning: DMI blacklist says broken, but acpi XSDT forced\n");
1350+
}
1351+
return 0;
1352+
}
1353+
13431354
static int __init dmi_disable_acpi(const struct dmi_system_id *d)
13441355
{
13451356
if (!acpi_force) {
@@ -1464,6 +1475,19 @@ static const struct dmi_system_id acpi_dmi_table[] __initconst = {
14641475
DMI_MATCH(DMI_PRODUCT_NAME, "TravelMate 360"),
14651476
},
14661477
},
1478+
/*
1479+
* Boxes that need ACPI XSDT use disabled due to corrupted tables
1480+
*/
1481+
{
1482+
.callback = disable_acpi_xsdt,
1483+
.ident = "Advantech DAC-BJ01",
1484+
.matches = {
1485+
DMI_MATCH(DMI_SYS_VENDOR, "NEC"),
1486+
DMI_MATCH(DMI_PRODUCT_NAME, "Bearlake CRB Board"),
1487+
DMI_MATCH(DMI_BIOS_VERSION, "V1.12"),
1488+
DMI_MATCH(DMI_BIOS_DATE, "02/01/2011"),
1489+
},
1490+
},
14671491
{}
14681492
};
14691493

0 commit comments

Comments
 (0)