Skip to content

Commit 2475291

Browse files
tmlindgregkh
authored andcommitted
usb: musb: Drop pointless PM runtime code for dsps glue
This already gets done automatically by PM runtime and we have a separate autosuspend timeout in musb_core.c. Reviewed-by: Johan Hovold <johan@kernel.org> Tested-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Tony Lindgren <tony@atomide.com> Signed-off-by: Bin Liu <b-liu@ti.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 536d599 commit 2475291

1 file changed

Lines changed: 2 additions & 20 deletions

File tree

drivers/usb/musb/musb_dsps.c

Lines changed: 2 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -783,28 +783,13 @@ static int dsps_probe(struct platform_device *pdev)
783783

784784
platform_set_drvdata(pdev, glue);
785785
pm_runtime_enable(&pdev->dev);
786-
pm_runtime_use_autosuspend(&pdev->dev);
787-
pm_runtime_set_autosuspend_delay(&pdev->dev, 200);
788-
789-
ret = pm_runtime_get_sync(&pdev->dev);
790-
if (ret < 0) {
791-
dev_err(&pdev->dev, "pm_runtime_get_sync FAILED");
792-
goto err2;
793-
}
794-
795786
ret = dsps_create_musb_pdev(glue, pdev);
796787
if (ret)
797-
goto err3;
798-
799-
pm_runtime_mark_last_busy(&pdev->dev);
800-
pm_runtime_put_autosuspend(&pdev->dev);
788+
goto err;
801789

802790
return 0;
803791

804-
err3:
805-
pm_runtime_put_sync(&pdev->dev);
806-
err2:
807-
pm_runtime_dont_use_autosuspend(&pdev->dev);
792+
err:
808793
pm_runtime_disable(&pdev->dev);
809794
return ret;
810795
}
@@ -815,9 +800,6 @@ static int dsps_remove(struct platform_device *pdev)
815800

816801
platform_device_unregister(glue->musb);
817802

818-
/* disable usbss clocks */
819-
pm_runtime_dont_use_autosuspend(&pdev->dev);
820-
pm_runtime_put_sync(&pdev->dev);
821803
pm_runtime_disable(&pdev->dev);
822804

823805
return 0;

0 commit comments

Comments
 (0)