Input: adi - make array seq static, reduces object code size

Colin Ian King · dtor · commit 1bf21b3373df · 2017-09-04T09:28:15.000-07:00
Don't populate the array seq on the stack, instead make it static.
Makes the object code smaller by over 170 bytes:

Before:
   text	   data	    bss	    dec	    hex	filename
  13227	   3232	      0	  16459	   404b	drivers/input/joystick/adi.o

After:
   text	   data	    bss	    dec	    hex	filename
  12957	   3328	      0	  16285	   3f9d	drivers/input/joystick/adi.o

Signed-off-by: Colin Ian King &lt;colin.king@canonical.com&gt;
Signed-off-by: Dmitry Torokhov &lt;dmitry.torokhov@gmail.com&gt;
diff --git a/drivers/input/joystick/adi.c b/drivers/input/joystick/adi.c
@@ -313,7 +313,7 @@ static void adi_close(struct input_dev *dev)
 
 static void adi_init_digital(struct gameport *gameport)
 {
-	int seq[] = { 4, -2, -3, 10, -6, -11, -7, -9, 11, 0 };
+	static const int seq[] = { 4, -2, -3, 10, -6, -11, -7, -9, 11, 0 };
 	int i;
 
 	for (i = 0; seq[i]; i++) {

Original file line number	Diff line number	Diff line change
`@@ -313,7 +313,7 @@ static void adi_close(struct input_dev *dev)`
`313`	`313`
`314`	`314`	`static void adi_init_digital(struct gameport *gameport)`
`315`	`315`	`{`
`316`		`- int seq[] = { 4, -2, -3, 10, -6, -11, -7, -9, 11, 0 };`
	`316`	`+ static const int seq[] = { 4, -2, -3, 10, -6, -11, -7, -9, 11, 0 };`
`317`	`317`	`int i;`
`318`	`318`
`319`	`319`	`for (i = 0; seq[i]; i++) {`