ipmi: Fix ioremap error handling in bt-bmc

shenki · cminyard · commit 1a377a79211a · 2016-09-29T19:05:06.000-05:00
devm_ioremap_resource returns ERR_PTR so we can't check for NULL.

Signed-off-by: Joel Stanley &lt;joel@jms.id.au&gt;
Acked-by: Cédric Le Goater &lt;clg@kaod.org&gt;
Signed-off-by: Corey Minyard &lt;cminyard@mvista.com&gt;
diff --git a/drivers/char/ipmi/bt-bmc.c b/drivers/char/ipmi/bt-bmc.c
@@ -438,8 +438,8 @@ static int bt_bmc_probe(struct platform_device *pdev)
 	}
 
 	bt_bmc->base = devm_ioremap_resource(&pdev->dev, res);
-	if (!bt_bmc->base)
-		return -ENOMEM;
+	if (IS_ERR(bt_bmc->base))
+		return PTR_ERR(bt_bmc->base);
 
 	mutex_init(&bt_bmc->mutex);
 	init_waitqueue_head(&bt_bmc->queue);

Original file line number	Diff line number	Diff line change
`@@ -438,8 +438,8 @@ static int bt_bmc_probe(struct platform_device *pdev)`
`438`	`438`	`}`
`439`	`439`
`440`	`440`	`bt_bmc->base = devm_ioremap_resource(&pdev->dev, res);`
`441`		`- if (!bt_bmc->base)`
`442`		`- return -ENOMEM;`
	`441`	`+ if (IS_ERR(bt_bmc->base))`
	`442`	`+ return PTR_ERR(bt_bmc->base);`
`443`	`443`
`444`	`444`	`mutex_init(&bt_bmc->mutex);`
`445`	`445`	`init_waitqueue_head(&bt_bmc->queue);`