Skip to content

Commit 0c28707

Browse files
yanmarkmangregkh
authored andcommitted
net: mvpp2: do not disable GMAC padding
commit e749aca upstream. Short fragmented packets may never be sent by the hardware when padding is disabled. This patch stop modifying the GMAC padding bits, to leave them to their reset value (disabled). Fixes: 3919357 ("net: mvpp2: initialize the GMAC when using a port") Signed-off-by: Yan Markman <ymarkman@marvell.com> [Antoine: commit message] Signed-off-by: Antoine Tenart <antoine.tenart@free-electrons.com> Signed-off-by: David S. Miller <davem@davemloft.net> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 3abb4c1 commit 0c28707

1 file changed

Lines changed: 0 additions & 9 deletions

File tree

  • drivers/net/ethernet/marvell

drivers/net/ethernet/marvell/mvpp2.c

Lines changed: 0 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -4552,22 +4552,13 @@ static void mvpp2_port_mii_gmac_configure_mode(struct mvpp2_port *port)
45524552
MVPP22_CTRL4_QSGMII_BYPASS_ACTIVE;
45534553
val &= ~MVPP22_CTRL4_EXT_PIN_GMII_SEL;
45544554
writel(val, port->base + MVPP22_GMAC_CTRL_4_REG);
4555-
4556-
val = readl(port->base + MVPP2_GMAC_CTRL_2_REG);
4557-
val |= MVPP2_GMAC_DISABLE_PADDING;
4558-
val &= ~MVPP2_GMAC_FLOW_CTRL_MASK;
4559-
writel(val, port->base + MVPP2_GMAC_CTRL_2_REG);
45604555
} else if (phy_interface_mode_is_rgmii(port->phy_interface)) {
45614556
val = readl(port->base + MVPP22_GMAC_CTRL_4_REG);
45624557
val |= MVPP22_CTRL4_EXT_PIN_GMII_SEL |
45634558
MVPP22_CTRL4_SYNC_BYPASS_DIS |
45644559
MVPP22_CTRL4_QSGMII_BYPASS_ACTIVE;
45654560
val &= ~MVPP22_CTRL4_DP_CLK_SEL;
45664561
writel(val, port->base + MVPP22_GMAC_CTRL_4_REG);
4567-
4568-
val = readl(port->base + MVPP2_GMAC_CTRL_2_REG);
4569-
val &= ~MVPP2_GMAC_DISABLE_PADDING;
4570-
writel(val, port->base + MVPP2_GMAC_CTRL_2_REG);
45714562
}
45724563

45734564
/* The port is connected to a copper PHY */

0 commit comments

Comments
 (0)