Skip to content

Commit 050aaea

Browse files
committed
Merge tag 'sound-fix-4.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
Pull sound fixes from Takashi Iwai: "Just a few trivial small fixes" * tag 'sound-fix-4.9-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound: ALSA: line6: fix a crash in line6_hwdep_write() ALSA: seq: fix passing wrong pointer in function call of compatibility layer ALSA: hda - Fix a failure of micmute led when having multi adcs ALSA: line6: Fix POD X3 Live audio input
2 parents b26b5ef + fdd8218 commit 050aaea

5 files changed

Lines changed: 7 additions & 6 deletions

File tree

sound/core/seq/seq_compat.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ static int snd_seq_call_port_info_ioctl(struct snd_seq_client *client, unsigned
5858
goto error;
5959
data->kernel = NULL;
6060

61-
err = snd_seq_kernel_client_ctl(client->number, cmd, &data);
61+
err = snd_seq_kernel_client_ctl(client->number, cmd, data);
6262
if (err < 0)
6363
goto error;
6464

sound/pci/hda/dell_wmi_helper.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ static void alc_fixup_dell_wmi(struct hda_codec *codec,
4949
removefunc = true;
5050
if (dell_led_set_func(DELL_LED_MICMUTE, false) >= 0) {
5151
dell_led_value = 0;
52-
if (spec->gen.num_adc_nids > 1)
52+
if (spec->gen.num_adc_nids > 1 && !spec->gen.dyn_adc_switch)
5353
codec_dbg(codec, "Skipping micmute LED control due to several ADCs");
5454
else {
5555
dell_old_cap_hook = spec->gen.cap_sync_hook;

sound/pci/hda/thinkpad_helper.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ static void hda_fixup_thinkpad_acpi(struct hda_codec *codec,
6262
removefunc = false;
6363
}
6464
if (led_set_func(TPACPI_LED_MICMUTE, false) >= 0) {
65-
if (spec->num_adc_nids > 1)
65+
if (spec->num_adc_nids > 1 && !spec->dyn_adc_switch)
6666
codec_dbg(codec,
6767
"Skipping micmute LED control due to several ADCs");
6868
else {

sound/usb/line6/driver.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -604,8 +604,8 @@ line6_hwdep_write(struct snd_hwdep *hwdep, const char __user *data, long count,
604604
}
605605

606606
data_copy = memdup_user(data, count);
607-
if (IS_ERR(ERR_PTR))
608-
return -ENOMEM;
607+
if (IS_ERR(data_copy))
608+
return PTR_ERR(data_copy);
609609

610610
rv = line6_send_raw_message(line6, data_copy, count);
611611

sound/usb/line6/podhd.c

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -317,7 +317,8 @@ static int podhd_init(struct usb_line6 *line6,
317317
if (pod->line6.properties->capabilities & LINE6_CAP_PCM) {
318318
/* initialize PCM subsystem: */
319319
err = line6_init_pcm(line6,
320-
(id->driver_info == LINE6_PODX3) ? &podx3_pcm_properties :
320+
(id->driver_info == LINE6_PODX3 ||
321+
id->driver_info == LINE6_PODX3LIVE) ? &podx3_pcm_properties :
321322
&podhd_pcm_properties);
322323
if (err < 0)
323324
return err;

0 commit comments

Comments
 (0)