Skip to content

Commit 0472707

Browse files
Dominik Brodowskigregkh
authored andcommitted
selftests/x86: Do not rely on "int $0x80" in test_mremap_vdso.c
commit 2cbc0d6 upstream. On 64-bit builds, we should not rely on "int $0x80" working (it only does if CONFIG_IA32_EMULATION=y is enabled). Without this patch, the move test may succeed, but the "int $0x80" causes a segfault, resulting in a false negative output of this self-test. Signed-off-by: Dominik Brodowski <linux@dominikbrodowski.net> Cc: Andy Lutomirski <luto@kernel.org> Cc: Dmitry Safonov <dsafonov@virtuozzo.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-kselftest@vger.kernel.org Cc: shuah@kernel.org Link: http://lkml.kernel.org/r/20180211111013.16888-4-linux@dominikbrodowski.net Signed-off-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 60d7b9c commit 0472707

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

tools/testing/selftests/x86/test_mremap_vdso.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -90,8 +90,12 @@ int main(int argc, char **argv, char **envp)
9090
vdso_size += PAGE_SIZE;
9191
}
9292

93+
#ifdef __i386__
9394
/* Glibc is likely to explode now - exit with raw syscall */
9495
asm volatile ("int $0x80" : : "a" (__NR_exit), "b" (!!ret));
96+
#else /* __x86_64__ */
97+
syscall(SYS_exit, ret);
98+
#endif
9599
} else {
96100
int status;
97101

0 commit comments

Comments
 (0)