Skip to content

Commit 022321a

Browse files
tasksetgregkh
authored andcommitted
platform/chrome: wilco_ec: fix use after free issue
[ Upstream commit 856a0a6 ] This is caused by dereferencing 'dev_data' after put_device() in the telem_device_remove() function. This patch just moves the put_device() down a bit to avoid this issue. Fixes: 1210d1e ("platform/chrome: wilco_ec: Add telemetry char device interface") Signed-off-by: Wen Yang <wenyang@linux.alibaba.com> Cc: Benson Leung <bleung@chromium.org> Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com> Cc: Nick Crews <ncrews@chromium.org> Cc: linux-kernel@vger.kernel.org Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com> Signed-off-by: Sasha Levin <sashal@kernel.org>
1 parent 074fd02 commit 022321a

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

drivers/platform/chrome/wilco_ec/telemetry.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -406,8 +406,8 @@ static int telem_device_remove(struct platform_device *pdev)
406406
struct telem_device_data *dev_data = platform_get_drvdata(pdev);
407407

408408
cdev_device_del(&dev_data->cdev, &dev_data->dev);
409-
put_device(&dev_data->dev);
410409
ida_simple_remove(&telem_ida, MINOR(dev_data->dev.devt));
410+
put_device(&dev_data->dev);
411411

412412
return 0;
413413
}

0 commit comments

Comments
 (0)