usb: gadget: udc: remove pointer dereference after free

GustavoARSilva · gregkh · commit 02197d86c56d · 2017-12-25T14:23:38.000+01:00
[ Upstream commit 1f45926 ] Remove pointer dereference after free. Addresses-Coverity-ID: 1091173 Acked-by: Michal Nazarewicz <mina86@mina86.com> Signed-off-by: Gustavo A. R. Silva <garsilva@embeddedor.com> Signed-off-by: Felipe Balbi <felipe.balbi@linux.intel.com> Signed-off-by: Sasha Levin <alexander.levin@verizon.com> Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
diff --git a/drivers/usb/gadget/udc/pch_udc.c b/drivers/usb/gadget/udc/pch_udc.c
@@ -1523,7 +1523,6 @@ static void pch_udc_free_dma_chain(struct pch_udc_dev *dev,
 		td = phys_to_virt(addr);
 		addr2 = (dma_addr_t)td->next;
 		pci_pool_free(dev->data_requests, td, addr);
-		td->next = 0x00;
 		addr = addr2;
 	}
 	req->chain_len = 1;

Original file line number	Diff line number	Diff line change
`@@ -1523,7 +1523,6 @@ static void pch_udc_free_dma_chain(struct pch_udc_dev *dev,`
`1523`	`1523`	`td = phys_to_virt(addr);`
`1524`	`1524`	`addr2 = (dma_addr_t)td->next;`
`1525`	`1525`	`pci_pool_free(dev->data_requests, td, addr);`
`1526`		`- td->next = 0x00;`
`1527`	`1526`	`addr = addr2;`
`1528`	`1527`	`}`
`1529`	`1528`	`req->chain_len = 1;`