Skip to content

Commit fbb8ed6

Browse files
rtla/tests: Run Test::Harness in verbose mode
Add -v flag to prove command to also print the names of tests that succeeded, not only those that failed, to allow easier debugging of the test suite. Also, drop printing the option and value to stdout in check_with_osnoise_options, which was a debugging print that was accidentally left in the final commit, and which would be otherwise now visible in make check output, as stdout is no longer suppressed. Suggested-by: Crystal Wood <crwood@redhat.com> Reviewed-by: Wander Lairson Costa <wander@redhat.com> Link: https://lore.kernel.org/r/20251126144205.331954-6-tglozar@redhat.com Signed-off-by: Tomas Glozar <tglozar@redhat.com>
1 parent 5525aeb commit fbb8ed6

2 files changed

Lines changed: 1 addition & 2 deletions

File tree

tools/tracing/rtla/Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -110,6 +110,6 @@ clean: doc_clean fixdep-clean
110110
$(Q)rm -rf feature
111111
$(Q)rm -f src/timerlat.bpf.o src/timerlat.skel.h example/timerlat_bpf_action.o
112112
check: $(RTLA) tests/bpf/bpf_action_map.o
113-
RTLA=$(RTLA) BPFTOOL=$(SYSTEM_BPFTOOL) prove -o -f tests/
113+
RTLA=$(RTLA) BPFTOOL=$(SYSTEM_BPFTOOL) prove -o -f -v tests/
114114
examples: example/timerlat_bpf_action.o
115115
.PHONY: FORCE clean check

tools/tracing/rtla/tests/engine.sh

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,6 @@ check_with_osnoise_options() {
105105
[ "$1" == "" ] && continue
106106
option=$(echo $1 | cut -d '=' -f 1)
107107
value=$(echo $1 | cut -d '=' -f 2)
108-
echo "option: $option, value: $value"
109108
echo "$value" > "/sys/kernel/tracing/osnoise/$option" || return 1
110109
done
111110
fi

0 commit comments

Comments
 (0)