Skip to content

Commit fb084e4

Browse files
rtauro1895rodrigovivi
authored andcommitted
drm/xe/xe_survivability: Remove unused index
Remove unused index variable and fix for loop. Fixes: f4e9fc9 ("drm/xe/xe_survivability: Redesign survivability mode") Reported-by: Nathan Chancellor <nathan@kernel.org> Closes: https://lore.kernel.org/intel-xe/20251210075757.GA1206705@ax162/ Signed-off-by: Riana Tauro <riana.tauro@intel.com> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com> Link: https://patch.msgid.link/20251218105151.586575-5-riana.tauro@intel.com Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 9dde74f commit fb084e4

1 file changed

Lines changed: 4 additions & 11 deletions

File tree

drivers/gpu/drm/xe/xe_survivability_mode.c

Lines changed: 4 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -128,11 +128,6 @@ xe_survivability_attribute *dev_attr_to_survivability_attr(struct device_attribu
128128
return container_of(attr, struct xe_survivability_attribute, attr);
129129
}
130130

131-
static u32 aux_history_offset(u32 reg_value)
132-
{
133-
return REG_FIELD_GET(AUXINFO_HISTORY_OFFSET, reg_value);
134-
}
135-
136131
static void set_survivability_info(struct xe_mmio *mmio, u32 *info, int id)
137132
{
138133
info[id] = xe_mmio_read32(mmio, PCODE_SCRATCH(id));
@@ -144,7 +139,6 @@ static void populate_survivability_info(struct xe_device *xe)
144139
u32 *info = survivability->info;
145140
struct xe_mmio *mmio;
146141
u32 id = 0, reg_value;
147-
int index;
148142

149143
mmio = xe_root_tile_mmio(xe);
150144
set_survivability_info(mmio, info, CAPABILITY_INFO);
@@ -162,13 +156,12 @@ static void populate_survivability_info(struct xe_device *xe)
162156
set_survivability_info(mmio, info, POSTCODE_TRACE_OVERFLOW);
163157
}
164158

159+
/* Traverse the linked list of aux info registers */
165160
if (reg_value & AUXINFO_SUPPORT) {
166-
id = REG_FIELD_GET(AUXINFO_REG_OFFSET, reg_value);
167-
168-
for (index = 0; id >= AUX_INFO0 && id < MAX_SCRATCH_REG; index++) {
161+
for (id = REG_FIELD_GET(AUXINFO_REG_OFFSET, reg_value);
162+
id >= AUX_INFO0 && id < MAX_SCRATCH_REG;
163+
id = REG_FIELD_GET(AUXINFO_HISTORY_OFFSET, info[id]))
169164
set_survivability_info(mmio, info, id);
170-
id = aux_history_offset(info[id]);
171-
}
172165
}
173166
}
174167

0 commit comments

Comments
 (0)