Skip to content

Commit f7bd985

Browse files
committed
memory: tegra-mc: Simplify printing PTR_ERR with dev_err_probe
Use dev_err_probe() to simplify the code and fix Coccinelle warning: tegra/mc.c:513:52-59: WARNING: Consider using %pe to print PTR_ERR() Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com> Acked-by: Thierry Reding <treding@nvidia.com> Link: https://patch.msgid.link/20260226-memory-simplify-v1-3-ccb94f378628@oss.qualcomm.com Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
1 parent 2ac5ba4 commit f7bd985

1 file changed

Lines changed: 5 additions & 8 deletions

File tree

  • drivers/memory/tegra

drivers/memory/tegra/mc.c

Lines changed: 5 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -507,21 +507,18 @@ int tegra30_mc_probe(struct tegra_mc *mc)
507507
int err;
508508

509509
mc->clk = devm_clk_get_optional(mc->dev, "mc");
510-
if (IS_ERR(mc->clk)) {
511-
dev_err(mc->dev, "failed to get MC clock: %ld\n", PTR_ERR(mc->clk));
512-
return PTR_ERR(mc->clk);
513-
}
510+
if (IS_ERR(mc->clk))
511+
return dev_err_probe(mc->dev, PTR_ERR(mc->clk),
512+
"failed to get MC clock\n");
514513

515514
/* ensure that debug features are disabled */
516515
mc_writel(mc, 0x00000000, MC_TIMING_CONTROL_DBG);
517516

518517
tegra_mc_setup_latency_allowance(mc);
519518

520519
err = tegra_mc_setup_timings(mc);
521-
if (err < 0) {
522-
dev_err(mc->dev, "failed to setup timings: %d\n", err);
523-
return err;
524-
}
520+
if (err < 0)
521+
return dev_err_probe(mc->dev, err, "failed to setup timings\n");
525522

526523
return 0;
527524
}

0 commit comments

Comments
 (0)