Skip to content

Commit f775276

Browse files
hcahcaVasily Gorbik
authored andcommitted
s390/xor: Fix xor_xc_2() inline assembly constraints
The inline assembly constraints for xor_xc_2() are incorrect. "bytes", "p1", and "p2" are input operands, while all three of them are modified within the inline assembly. Given that the function consists only of this inline assembly it seems unlikely that this may cause any problems, however fix this in any case. Fixes: 2cfc5f9 ("s390/xor: optimized xor routing using the XC instruction") Cc: stable@vger.kernel.org Signed-off-by: Heiko Carstens <hca@linux.ibm.com> Reviewed-by: Vasily Gorbik <gor@linux.ibm.com> Link: https://lore.kernel.org/r/20260302133500.1560531-2-hca@linux.ibm.com Signed-off-by: Vasily Gorbik <gor@linux.ibm.com>
1 parent 5f25805 commit f775276

1 file changed

Lines changed: 2 additions & 2 deletions

File tree

arch/s390/lib/xor.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@ static void xor_xc_2(unsigned long bytes, unsigned long * __restrict p1,
2828
" j 3f\n"
2929
"2: xc 0(1,%1),0(%2)\n"
3030
"3:"
31-
: : "d" (bytes), "a" (p1), "a" (p2)
32-
: "0", "cc", "memory");
31+
: "+d" (bytes), "+a" (p1), "+a" (p2)
32+
: : "0", "cc", "memory");
3333
}
3434

3535
static void xor_xc_3(unsigned long bytes, unsigned long * __restrict p1,

0 commit comments

Comments
 (0)