Skip to content

Commit f42f909

Browse files
leitaohtejun
authored andcommitted
workqueue: Use POOL_BH instead of WQ_BH when checking pool flags
pr_cont_worker_id() checks pool->flags against WQ_BH, which is a workqueue-level flag (defined in workqueue.h). Pool flags use a separate namespace with POOL_* constants (defined in workqueue.c). The correct constant is POOL_BH. Both WQ_BH and POOL_BH are defined as (1 << 0) so this has no behavioral impact, but it is semantically wrong and inconsistent with every other pool-level BH check in the file. Fixes: 4cb1ef6 ("workqueue: Implement BH workqueues to eventually replace tasklets") Signed-off-by: Breno Leitao <leitao@debian.org> Acked-by: Song Liu <song@kernel.org> Signed-off-by: Tejun Heo <tj@kernel.org>
1 parent c107785 commit f42f909

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

kernel/workqueue.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6274,7 +6274,7 @@ static void pr_cont_worker_id(struct worker *worker)
62746274
{
62756275
struct worker_pool *pool = worker->pool;
62766276

6277-
if (pool->flags & WQ_BH)
6277+
if (pool->flags & POOL_BH)
62786278
pr_cont("bh%s",
62796279
pool->attrs->nice == HIGHPRI_NICE_LEVEL ? "-hi" : "");
62806280
else

0 commit comments

Comments
 (0)