Skip to content

Commit f374ff7

Browse files
committed
Merge tag 'ata-7.0-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux
Pull ata fixes from Niklas Cassel: - ADATA SU680 SSDs are causing command timeouts when LPM is enabled. Enable the ATA_QUIRK_NOLPM quirk to prevent LPM from being enabled on these devices (Damien) - When receiving a REPORT SUPPORTED OPERATION CODES command with an invalid REPORTING OPTIONS format, sense data should have the field pointer set to byte 2 (the location of the REPORTING OPTIONS field) instead of incorrectly pointing to byte 1 (Damien) * tag 'ata-7.0-rc5' of git://git.kernel.org/pub/scm/linux/kernel/git/libata/linux: ata: libata-scsi: report correct sense field pointer in ata_scsiop_maint_in() ata: libata-core: disable LPM on ADATA SU680 SSD
2 parents 6ac5131 + e6d7eba commit f374ff7

2 files changed

Lines changed: 4 additions & 1 deletion

File tree

drivers/ata/libata-core.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -4188,6 +4188,9 @@ static const struct ata_dev_quirks_entry __ata_dev_quirks[] = {
41884188
{ "ST3320[68]13AS", "SD1[5-9]", ATA_QUIRK_NONCQ |
41894189
ATA_QUIRK_FIRMWARE_WARN },
41904190

4191+
/* ADATA devices with LPM issues. */
4192+
{ "ADATA SU680", NULL, ATA_QUIRK_NOLPM },
4193+
41914194
/* Seagate disks with LPM issues */
41924195
{ "ST1000DM010-2EP102", NULL, ATA_QUIRK_NOLPM },
41934196
{ "ST2000DM008-2FR102", NULL, ATA_QUIRK_NOLPM },

drivers/ata/libata-scsi.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3600,7 +3600,7 @@ static unsigned int ata_scsiop_maint_in(struct ata_device *dev,
36003600

36013601
if (cdb[2] != 1 && cdb[2] != 3) {
36023602
ata_dev_warn(dev, "invalid command format %d\n", cdb[2]);
3603-
ata_scsi_set_invalid_field(dev, cmd, 1, 0xff);
3603+
ata_scsi_set_invalid_field(dev, cmd, 2, 0xff);
36043604
return 0;
36053605
}
36063606

0 commit comments

Comments
 (0)