Skip to content

Commit ea5ea83

Browse files
walaclenticularis39
authored andcommitted
rtla: Use str_has_prefix() for option prefix check
The argument parsing code in timerlat_main() and osnoise_main() uses strncmp() with a length of 1 to check if the first argument starts with a dash, indicating an option flag was passed. Replace this pattern with str_has_prefix() for consistency with the rest of the codebase. While character comparison would be slightly more efficient, using str_has_prefix() provides better readability and maintains a uniform coding style throughout the rtla tool. Signed-off-by: Wander Lairson Costa <wander@redhat.com> Link: https://lore.kernel.org/r/20260309195040.1019085-14-wander@redhat.com Signed-off-by: Tomas Glozar <tglozar@redhat.com>
1 parent b3910a7 commit ea5ea83

2 files changed

Lines changed: 2 additions & 2 deletions

File tree

tools/tracing/rtla/src/osnoise.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1210,7 +1210,7 @@ int osnoise_main(int argc, char *argv[])
12101210

12111211
if ((strcmp(argv[1], "-h") == 0) || (strcmp(argv[1], "--help") == 0)) {
12121212
osnoise_usage(0);
1213-
} else if (strncmp(argv[1], "-", 1) == 0) {
1213+
} else if (str_has_prefix(argv[1], "-")) {
12141214
/* the user skipped the tool, call the default one */
12151215
run_tool(&osnoise_top_ops, argc, argv);
12161216
exit(0);

tools/tracing/rtla/src/timerlat.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -269,7 +269,7 @@ int timerlat_main(int argc, char *argv[])
269269

270270
if ((strcmp(argv[1], "-h") == 0) || (strcmp(argv[1], "--help") == 0)) {
271271
timerlat_usage(0);
272-
} else if (strncmp(argv[1], "-", 1) == 0) {
272+
} else if (str_has_prefix(argv[1], "-")) {
273273
/* the user skipped the tool, call the default one */
274274
run_tool(&timerlat_top_ops, argc, argv);
275275
exit(0);

0 commit comments

Comments
 (0)