mctp: i2c: fix skb memory leak in receive path

haiyuewa · Paolo Abeni · commit e3f5e0f22cfc · 2026-03-10T11:10:55.000+01:00
When 'midev->allow_rx' is false, the newly allocated skb isn't consumed by netif_rx(), it needs to free the skb directly. Fixes: f5b8abf ("mctp i2c: MCTP I2C binding driver") Signed-off-by: Haiyue Wang <haiyuewa@163.com> Link: https://patch.msgid.link/20260305143240.97592-1-haiyuewa@163.com Signed-off-by: Paolo Abeni <pabeni@redhat.com>
diff --git a/drivers/net/mctp/mctp-i2c.c b/drivers/net/mctp/mctp-i2c.c
@@ -343,6 +343,7 @@ static int mctp_i2c_recv(struct mctp_i2c_dev *midev)
 	} else {
 		status = NET_RX_DROP;
 		spin_unlock_irqrestore(&midev->lock, flags);
+		kfree_skb(skb);
 	}
 
 	if (status == NET_RX_SUCCESS) {

Original file line number	Diff line number	Diff line change
`@@ -343,6 +343,7 @@ static int mctp_i2c_recv(struct mctp_i2c_dev *midev)`
`343`	`343`	`} else {`
`344`	`344`	`status = NET_RX_DROP;`
`345`	`345`	`spin_unlock_irqrestore(&midev->lock, flags);`
	`346`	`+ kfree_skb(skb);`
`346`	`347`	`}`
`347`	`348`
`348`	`349`	`if (status == NET_RX_SUCCESS) {`