Skip to content

Commit e2628e6

Browse files
dceraolorodrigovivi
authored andcommitted
drm/xe/pxp: Clean up termination status on failure
If the PXP HW termination fails during PXP start, the normal completion code won't be called, so the termination will remain uncomplete. To avoid unnecessary waits, mark the termination as completed from the error path. Note that we already do this if the termination fails when handling a termination irq from the HW. Fixes: f8caa80 ("drm/xe/pxp: Add PXP queue tracking and session start") Signed-off-by: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> Cc: Alan Previn Teres Alexis <alan.previn.teres.alexis@intel.com> Cc: Julia Filipchuk <julia.filipchuk@intel.com> Reviewed-by: Julia Filipchuk <julia.filipchuk@intel.com> Link: https://patch.msgid.link/20260324153718.3155504-7-daniele.ceraolospurio@intel.com (cherry picked from commit 5d9e708d2a69ab1f64a17aec810cd7c70c5b9fab) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 7b9a3a9 commit e2628e6

1 file changed

Lines changed: 1 addition & 0 deletions

File tree

drivers/gpu/drm/xe/xe_pxp.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -583,6 +583,7 @@ static int pxp_start(struct xe_pxp *pxp, u8 type)
583583
drm_err(&pxp->xe->drm, "PXP termination failed before start\n");
584584
mutex_lock(&pxp->mutex);
585585
pxp->status = XE_PXP_ERROR;
586+
complete_all(&pxp->termination);
586587

587588
goto out_unlock;
588589
}

0 commit comments

Comments
 (0)