Skip to content

Commit de0aca1

Browse files
Eliot CourtneyDanilo Krummrich
authored andcommitted
gpu: nova-core: bitfield: fix broken Default implementation
The current implementation does not actually set the default values for the fields in the bitfield. Fixes: 3fa145b ("gpu: nova-core: register: generate correct `Default` implementation") Signed-off-by: Eliot Courtney <ecourtney@nvidia.com> Link: https://patch.msgid.link/20260401-fix-bitfield-v2-1-2fa68c98114a@nvidia.com Signed-off-by: Danilo Krummrich <dakr@kernel.org>
1 parent 0e0ffbc commit de0aca1

1 file changed

Lines changed: 2 additions & 3 deletions

File tree

drivers/gpu/nova-core/bitfield.rs

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -314,12 +314,11 @@ macro_rules! bitfield {
314314
/// Returns a value for the bitfield where all fields are set to their default value.
315315
impl ::core::default::Default for $name {
316316
fn default() -> Self {
317-
#[allow(unused_mut)]
318-
let mut value = Self(Default::default());
317+
let value = Self(Default::default());
319318

320319
::kernel::macros::paste!(
321320
$(
322-
value.[<set_ $field>](Default::default());
321+
let value = value.[<set_ $field>](Default::default());
323322
)*
324323
);
325324

0 commit comments

Comments
 (0)