Skip to content

Commit dccd324

Browse files
Daeho JeongJaegeuk Kim
authored andcommitted
f2fs: fix to skip empty sections in f2fs_get_victim
In age-based victim selection (ATGC, AT_SSR, or GC_CB), f2fs_get_victim can encounter sections with zero valid blocks. This situation often arises when checkpoint is disabled or due to race conditions between SIT updates and dirty list management. In such cases, f2fs_get_section_mtime() returns INVALID_MTIME, which subsequently triggers a fatal f2fs_bug_on(sbi, mtime == INVALID_MTIME) in add_victim_entry() or get_cb_cost(). This patch adds a check in f2fs_get_victim's selection loop to skip sections with no valid blocks. This prevents unnecessary age calculations for empty sections and avoids the associated kernel panic. This change also allows removing redundant checks in add_victim_entry(). Signed-off-by: Daeho Jeong <daehojeong@google.com> Reviewed-by: Chao Yu <chao@kernel.org> Signed-off-by: Jaegeuk Kim <jaegeuk@kernel.org>
1 parent fe9b8b3 commit dccd324

1 file changed

Lines changed: 3 additions & 0 deletions

File tree

fs/f2fs/gc.c

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -910,6 +910,9 @@ int f2fs_get_victim(struct f2fs_sb_info *sbi, unsigned int *result,
910910
if (!f2fs_segment_has_free_slot(sbi, segno))
911911
goto next;
912912
}
913+
914+
if (!get_valid_blocks(sbi, segno, true))
915+
goto next;
913916
}
914917

915918
if (gc_type == BG_GC && test_bit(secno, dirty_i->victim_secmap))

0 commit comments

Comments
 (0)