Skip to content

Commit dad4964

Browse files
Chunyu-Huakpm00
authored andcommitted
selftests/mm: split_huge_page_test: skip the test when thp is not available
When thp is not enabled on some kernel config such as realtime kernel, the test will report failure. Fix the false positive by skipping the test directly when thp is not enabled. Tested with thp disabled kernel: Before The fix: # -------------------------------------------------- # running ./split_huge_page_test /tmp/xfs_dir_Ywup9p # -------------------------------------------------- # TAP version 13 # Bail out! Reading PMD pagesize failed # # Totals: pass:0 fail:0 xfail:0 xpass:0 skip:0 error:0 # [FAIL] not ok 61 split_huge_page_test /tmp/xfs_dir_Ywup9p # exit=1 After the fix: # -------------------------------------------------- # running ./split_huge_page_test /tmp/xfs_dir_YHPUPl # -------------------------------------------------- # TAP version 13 # 1..0 # SKIP Transparent Hugepages not available # [SKIP] ok 6 split_huge_page_test /tmp/xfs_dir_YHPUPl # SKIP Link: https://lore.kernel.org/20260402014543.1671131-6-chuhu@redhat.com Signed-off-by: Chunyu Hu <chuhu@redhat.com> Acked-by: David Hildenbrand (Arm) <david@kernel.org> Reviewed-by: Mike Rapoport (Microsoft) <rppt@kernel.org> Reviewed-by: Lorenzo Stoakes (Oracle) <ljs@kernel.org> Reviewed-by: Zi Yan <ziy@nvidia.com> Cc: Li Wang <liwang@redhat.com> Cc: Nico Pache <npache@redhat.com> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
1 parent a784a3a commit dad4964

1 file changed

Lines changed: 4 additions & 0 deletions

File tree

tools/testing/selftests/mm/split_huge_page_test.c

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@
2121
#include <time.h>
2222
#include "vm_util.h"
2323
#include "kselftest.h"
24+
#include "thp_settings.h"
2425

2526
uint64_t pagesize;
2627
unsigned int pageshift;
@@ -757,6 +758,9 @@ int main(int argc, char **argv)
757758
ksft_finished();
758759
}
759760

761+
if (!thp_is_enabled())
762+
ksft_exit_skip("Transparent Hugepages not available\n");
763+
760764
if (argc > 1)
761765
optional_xfs_path = argv[1];
762766

0 commit comments

Comments
 (0)