Skip to content

Commit d7ea849

Browse files
deepanshu406aalexandrovich
authored andcommitted
fs/ntfs3: fix missing run load for vcn0 in attr_data_get_block_locked()
When a compressed or sparse attribute has its clusters frame-aligned, vcn is rounded down to the frame start using cmask, which can result in vcn != vcn0. In this case, vcn and vcn0 may reside in different attribute segments. The code already handles the case where vcn is in a different segment by loading its runs before allocation. However, it fails to load runs for vcn0 when vcn0 resides in a different segment than vcn. This causes run_lookup_entry() to return SPARSE_LCN for vcn0 since its segment was never loaded into the in-memory run list, triggering the WARN_ON(1). Fix this by adding a missing check for vcn0 after the existing vcn segment check. If vcn0 falls outside the current segment range [svcn, evcn1), find and load the attribute segment containing vcn0 before performing the run lookup. The following scenario triggers the bug: attr_data_get_block_locked() vcn = vcn0 & cmask <- vcn != vcn0 after frame alignment load runs for vcn segment <- vcn0 segment not loaded! attr_allocate_clusters() <- allocation succeeds run_lookup_entry(vcn0) <- vcn0 not in run -> SPARSE_LCN WARN_ON(1) <- bug fires here! Reported-by: syzbot+c1e9aedbd913fadad617@syzkaller.appspotmail.com Closes: https://syzkaller.appspot.com/bug?extid=c1e9aedbd913fadad617 Fixes: c380b52 ("fs/ntfs3: Change new sparse cluster processing") Signed-off-by: Deepanshu Kartikey <Kartikey406@gmail.com> Signed-off-by: Konstantin Komarov <almaz.alexandrovich@paragon-software.com>
1 parent 81ad9e6 commit d7ea849

1 file changed

Lines changed: 15 additions & 0 deletions

File tree

fs/ntfs3/attrib.c

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1152,6 +1152,21 @@ int attr_data_get_block_locked(struct ntfs_inode *ni, CLST vcn, CLST clen,
11521152
if (err)
11531153
goto out;
11541154
}
1155+
1156+
if (vcn0 < svcn || evcn1 <= vcn0) {
1157+
struct ATTRIB *attr2;
1158+
1159+
attr2 = ni_find_attr(ni, attr_b, &le_b, ATTR_DATA, NULL,
1160+
0, &vcn0, &mi);
1161+
if (!attr2) {
1162+
err = -EINVAL;
1163+
goto out;
1164+
}
1165+
err = attr_load_runs(attr2, ni, run, NULL);
1166+
if (err)
1167+
goto out;
1168+
}
1169+
11551170
da = false; /* no delalloc for compressed file. */
11561171
}
11571172

0 commit comments

Comments
 (0)