Skip to content

Commit d761085

Browse files
khfengrafaeljw
authored andcommitted
ACPI: APEI: GHES: Add NVIDIA vendor CPER record handler
Add support for decoding NVIDIA-specific CPER sections delivered via the APEI GHES vendor record notifier chain. NVIDIA hardware generates vendor-specific CPER sections containing error signatures and diagnostic register dumps. This implementation registers a notifier_block with the GHES vendor record notifier and decodes these sections, printing error details via dev_info(). The driver binds to ACPI device NVDA2012, present on NVIDIA server platforms. The NVIDIA CPER section contains a fixed header with error metadata (signature, error type, severity, socket) followed by variable-length register address-value pairs for hardware diagnostics. This work is based on libcper [1]. Example output: nvidia-ghes NVDA2012:00: NVIDIA CPER section, error_data_length: 544 nvidia-ghes NVDA2012:00: signature: CMET-INFO nvidia-ghes NVDA2012:00: error_type: 0 nvidia-ghes NVDA2012:00: error_instance: 0 nvidia-ghes NVDA2012:00: severity: 3 nvidia-ghes NVDA2012:00: socket: 0 nvidia-ghes NVDA2012:00: number_regs: 32 nvidia-ghes NVDA2012:00: instance_base: 0x0000000000000000 nvidia-ghes NVDA2012:00: register[0]: address=0x8000000100000000 value=0x0000000100000000 openbmc/libcper@683e055061ce [1] Reviewed-by: Jonathan Cameron <jonathan.cameron@huawei.com> Signed-off-by: Kai-Heng Feng <kaihengf@nvidia.com> [ rjw: Changelog edits ] Link: https://patch.msgid.link/20260330094203.38022-4-kaihengf@nvidia.com Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 35bdb5d commit d761085

4 files changed

Lines changed: 170 additions & 0 deletions

File tree

MAINTAINERS

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -18919,6 +18919,12 @@ S: Maintained
1891918919
F: drivers/video/fbdev/nvidia/
1892018920
F: drivers/video/fbdev/riva/
1892118921

18922+
NVIDIA GHES VENDOR CPER RECORD HANDLER
18923+
M: Kai-Heng Feng <kaihengf@nvidia.com>
18924+
L: linux-acpi@vger.kernel.org
18925+
S: Maintained
18926+
F: drivers/acpi/apei/nvidia-ghes.c
18927+
1892218928
NVIDIA VRS RTC DRIVER
1892318929
M: Shubhi Garg <shgarg@nvidia.com>
1892418930
L: linux-tegra@vger.kernel.org

drivers/acpi/apei/Kconfig

Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -74,6 +74,20 @@ config ACPI_APEI_EINJ_CXL
7474

7575
If unsure say 'n'
7676

77+
config ACPI_APEI_GHES_NVIDIA
78+
tristate "NVIDIA GHES vendor record handler"
79+
depends on ACPI_APEI_GHES
80+
help
81+
Support for decoding NVIDIA-specific CPER sections delivered via
82+
the APEI GHES vendor record notifier chain. Registers a handler
83+
for the NVIDIA section GUID and logs error signatures, severity,
84+
socket, and diagnostic register address-value pairs.
85+
86+
Enable on NVIDIA server platforms (e.g. DGX, HGX) that expose
87+
ACPI device NVDA2012 in their firmware tables.
88+
89+
If unsure, say N.
90+
7791
config ACPI_APEI_ERST_DEBUG
7892
tristate "APEI Error Record Serialization Table (ERST) Debug Support"
7993
depends on ACPI_APEI

drivers/acpi/apei/Makefile

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,6 @@ obj-$(CONFIG_ACPI_APEI_EINJ) += einj.o
1010
einj-y := einj-core.o
1111
einj-$(CONFIG_ACPI_APEI_EINJ_CXL) += einj-cxl.o
1212
obj-$(CONFIG_ACPI_APEI_ERST_DEBUG) += erst-dbg.o
13+
obj-$(CONFIG_ACPI_APEI_GHES_NVIDIA) += ghes-nvidia.o
1314

1415
apei-y := apei-base.o hest.o erst.o bert.o

drivers/acpi/apei/ghes-nvidia.c

Lines changed: 149 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,149 @@
1+
// SPDX-License-Identifier: GPL-2.0-only
2+
/*
3+
* NVIDIA GHES vendor record handler
4+
*
5+
* Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.
6+
*/
7+
8+
#include <linux/acpi.h>
9+
#include <linux/module.h>
10+
#include <linux/platform_device.h>
11+
#include <linux/types.h>
12+
#include <linux/uuid.h>
13+
#include <acpi/ghes.h>
14+
15+
static const guid_t nvidia_sec_guid =
16+
GUID_INIT(0x6d5244f2, 0x2712, 0x11ec,
17+
0xbe, 0xa7, 0xcb, 0x3f, 0xdb, 0x95, 0xc7, 0x86);
18+
19+
struct cper_sec_nvidia {
20+
char signature[16];
21+
__le16 error_type;
22+
__le16 error_instance;
23+
u8 severity;
24+
u8 socket;
25+
u8 number_regs;
26+
u8 reserved;
27+
__le64 instance_base;
28+
struct {
29+
__le64 addr;
30+
__le64 val;
31+
} regs[] __counted_by(number_regs);
32+
};
33+
34+
struct nvidia_ghes_private {
35+
struct notifier_block nb;
36+
struct device *dev;
37+
};
38+
39+
static void nvidia_ghes_print_error(struct device *dev,
40+
const struct cper_sec_nvidia *nvidia_err,
41+
size_t error_data_length, bool fatal)
42+
{
43+
const char *level = fatal ? KERN_ERR : KERN_INFO;
44+
size_t min_size;
45+
46+
dev_printk(level, dev, "signature: %.16s\n", nvidia_err->signature);
47+
dev_printk(level, dev, "error_type: %u\n", le16_to_cpu(nvidia_err->error_type));
48+
dev_printk(level, dev, "error_instance: %u\n", le16_to_cpu(nvidia_err->error_instance));
49+
dev_printk(level, dev, "severity: %u\n", nvidia_err->severity);
50+
dev_printk(level, dev, "socket: %u\n", nvidia_err->socket);
51+
dev_printk(level, dev, "number_regs: %u\n", nvidia_err->number_regs);
52+
dev_printk(level, dev, "instance_base: 0x%016llx\n",
53+
le64_to_cpu(nvidia_err->instance_base));
54+
55+
if (nvidia_err->number_regs == 0)
56+
return;
57+
58+
/*
59+
* Validate that all registers fit within error_data_length.
60+
* Each register pair is two little-endian u64s.
61+
*/
62+
min_size = struct_size(nvidia_err, regs, nvidia_err->number_regs);
63+
if (error_data_length < min_size) {
64+
dev_err(dev, "Invalid number_regs %u (section size %zu, need %zu)\n",
65+
nvidia_err->number_regs, error_data_length, min_size);
66+
return;
67+
}
68+
69+
for (int i = 0; i < nvidia_err->number_regs; i++)
70+
dev_printk(level, dev, "register[%d]: address=0x%016llx value=0x%016llx\n",
71+
i, le64_to_cpu(nvidia_err->regs[i].addr),
72+
le64_to_cpu(nvidia_err->regs[i].val));
73+
}
74+
75+
static int nvidia_ghes_notify(struct notifier_block *nb,
76+
unsigned long event, void *data)
77+
{
78+
struct acpi_hest_generic_data *gdata = data;
79+
struct nvidia_ghes_private *priv;
80+
const struct cper_sec_nvidia *nvidia_err;
81+
guid_t sec_guid;
82+
83+
import_guid(&sec_guid, gdata->section_type);
84+
if (!guid_equal(&sec_guid, &nvidia_sec_guid))
85+
return NOTIFY_DONE;
86+
87+
priv = container_of(nb, struct nvidia_ghes_private, nb);
88+
89+
if (acpi_hest_get_error_length(gdata) < sizeof(*nvidia_err)) {
90+
dev_err(priv->dev, "Section too small (%d < %zu)\n",
91+
acpi_hest_get_error_length(gdata), sizeof(*nvidia_err));
92+
return NOTIFY_OK;
93+
}
94+
95+
nvidia_err = acpi_hest_get_payload(gdata);
96+
97+
if (event >= GHES_SEV_RECOVERABLE)
98+
dev_err(priv->dev, "NVIDIA CPER section, error_data_length: %u\n",
99+
acpi_hest_get_error_length(gdata));
100+
else
101+
dev_info(priv->dev, "NVIDIA CPER section, error_data_length: %u\n",
102+
acpi_hest_get_error_length(gdata));
103+
104+
nvidia_ghes_print_error(priv->dev, nvidia_err, acpi_hest_get_error_length(gdata),
105+
event >= GHES_SEV_RECOVERABLE);
106+
107+
return NOTIFY_OK;
108+
}
109+
110+
static int nvidia_ghes_probe(struct platform_device *pdev)
111+
{
112+
struct nvidia_ghes_private *priv;
113+
int ret;
114+
115+
priv = devm_kmalloc(&pdev->dev, sizeof(*priv), GFP_KERNEL);
116+
if (!priv)
117+
return -ENOMEM;
118+
119+
*priv = (struct nvidia_ghes_private) {
120+
.nb.notifier_call = nvidia_ghes_notify,
121+
.dev = &pdev->dev,
122+
};
123+
124+
ret = devm_ghes_register_vendor_record_notifier(&pdev->dev, &priv->nb);
125+
if (ret)
126+
return dev_err_probe(&pdev->dev, ret,
127+
"Failed to register NVIDIA GHES vendor record notifier\n");
128+
129+
return 0;
130+
}
131+
132+
static const struct acpi_device_id nvidia_ghes_acpi_match[] = {
133+
{ "NVDA2012" },
134+
{ }
135+
};
136+
MODULE_DEVICE_TABLE(acpi, nvidia_ghes_acpi_match);
137+
138+
static struct platform_driver nvidia_ghes_driver = {
139+
.driver = {
140+
.name = "nvidia-ghes",
141+
.acpi_match_table = nvidia_ghes_acpi_match,
142+
},
143+
.probe = nvidia_ghes_probe,
144+
};
145+
module_platform_driver(nvidia_ghes_driver);
146+
147+
MODULE_AUTHOR("Kai-Heng Feng <kaihengf@nvidia.com>");
148+
MODULE_DESCRIPTION("NVIDIA GHES vendor CPER record handler");
149+
MODULE_LICENSE("GPL");

0 commit comments

Comments
 (0)