Skip to content

Commit d35a6db

Browse files
billy-tsaialexandrebelloni
authored andcommitted
i3c: mipi-i3c-hci: fix IBI payload length calculation for final status
In DMA mode, the IBI status descriptor encodes the payload using CHUNKS (number of chunks) and DATA_LENGTH (valid bytes in the last chunk). All preceding chunks are implicitly full-sized. The current code accumulates full chunk sizes for non-final status descriptors, but for the final status descriptor it only adds DATA_LENGTH. This ignores the contribution of the preceding full chunks described by the same final status entry. As a result, the computed IBI payload length is truncated whenever the final status spans multiple chunks. For example, with a chunk size of 4 bytes, CHUNKS=2 and DATA_LENGTH=1 should result in a total payload size of 5 bytes, but the current code reports only 1 byte. Fix the calculation by adding the size of (CHUNKS - 1) full chunks plus DATA_LENGTH for the last chunk. Fixes: 9ad9a52 ("i3c/master: introduce the mipi-i3c-hci driver") Signed-off-by: Billy Tsai <billy_tsai@aspeedtech.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> Link: https://patch.msgid.link/20260407-i3c-hci-dma-v2-1-a583187b9d22@aspeedtech.com Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
1 parent 0b73da9 commit d35a6db

1 file changed

Lines changed: 4 additions & 1 deletion

File tree

  • drivers/i3c/master/mipi-i3c-hci

drivers/i3c/master/mipi-i3c-hci/dma.c

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -754,7 +754,10 @@ static void hci_dma_process_ibi(struct i3c_hci *hci, struct hci_rh_data *rh)
754754
if (!(ibi_status & IBI_LAST_STATUS)) {
755755
ibi_size += chunks * rh->ibi_chunk_sz;
756756
} else {
757-
ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
757+
if (chunks) {
758+
ibi_size += (chunks - 1) * rh->ibi_chunk_sz;
759+
ibi_size += FIELD_GET(IBI_DATA_LENGTH, ibi_status);
760+
}
758761
last_ptr = ptr;
759762
break;
760763
}

0 commit comments

Comments
 (0)