Skip to content

Commit d30f75d

Browse files
committed
drm/i915/dp: Simplify computing the DSC compressed BPP for DP-MST
The minimum/maximum DSC input (i.e. pipe) and compressed (i.e. link) BPP limits are computed already in intel_dp_compute_config_limits(), so there is no need to do this again in mst_stream_dsc_compute_link_config() called later. Remove the corresponding alignments from the latter function and use the precomputed (aligned and within bounds) maximum pipe BPP and the min/max compressed BPP values instead as-is. Reviewed-by: Jouni Högander <jouni.hogander@intel.com> Signed-off-by: Imre Deak <imre.deak@intel.com> Link: https://patch.msgid.link/20251222153547.713360-21-imre.deak@intel.com
1 parent 3045a4e commit d30f75d

1 file changed

Lines changed: 6 additions & 42 deletions

File tree

drivers/gpu/drm/i915/display/intel_dp_mst.c

Lines changed: 6 additions & 42 deletions
Original file line numberDiff line numberDiff line change
@@ -463,57 +463,21 @@ static int mst_stream_dsc_compute_link_config(struct intel_dp *intel_dp,
463463
{
464464
struct intel_display *display = to_intel_display(intel_dp);
465465
struct intel_connector *connector = to_intel_connector(conn_state->connector);
466-
int num_bpc;
467-
u8 dsc_bpc[3] = {};
468-
int min_bpp, max_bpp, sink_min_bpp, sink_max_bpp;
469-
int min_compressed_bpp_x16, max_compressed_bpp_x16;
470-
int bpp_step_x16;
471466

472-
max_bpp = limits->pipe.max_bpp;
473-
min_bpp = limits->pipe.min_bpp;
474-
475-
num_bpc = drm_dp_dsc_sink_supported_input_bpcs(connector->dp.dsc_dpcd,
476-
dsc_bpc);
477-
478-
drm_dbg_kms(display->drm, "DSC Source supported min bpp %d max bpp %d\n",
479-
min_bpp, max_bpp);
480-
481-
sink_min_bpp = min_array(dsc_bpc, num_bpc) * 3;
482-
sink_max_bpp = max_array(dsc_bpc, num_bpc) * 3;
483-
484-
drm_dbg_kms(display->drm, "DSC Sink supported min bpp %d max bpp %d\n",
485-
sink_min_bpp, sink_max_bpp);
486-
487-
if (min_bpp < sink_min_bpp)
488-
min_bpp = sink_min_bpp;
489-
490-
if (max_bpp > sink_max_bpp)
491-
max_bpp = sink_max_bpp;
492-
493-
crtc_state->pipe_bpp = max_bpp;
494-
495-
min_compressed_bpp_x16 = limits->link.min_bpp_x16;
496-
max_compressed_bpp_x16 = limits->link.max_bpp_x16;
467+
crtc_state->pipe_bpp = limits->pipe.max_bpp;
497468

498469
drm_dbg_kms(display->drm,
499470
"DSC Sink supported compressed min bpp " FXP_Q4_FMT " compressed max bpp " FXP_Q4_FMT "\n",
500-
FXP_Q4_ARGS(min_compressed_bpp_x16), FXP_Q4_ARGS(max_compressed_bpp_x16));
501-
502-
bpp_step_x16 = intel_dp_dsc_bpp_step_x16(connector);
503-
504-
max_compressed_bpp_x16 = min(max_compressed_bpp_x16, fxp_q4_from_int(crtc_state->pipe_bpp) - bpp_step_x16);
505-
506-
drm_WARN_ON(display->drm, !is_power_of_2(bpp_step_x16));
507-
min_compressed_bpp_x16 = round_up(min_compressed_bpp_x16, bpp_step_x16);
508-
max_compressed_bpp_x16 = round_down(max_compressed_bpp_x16, bpp_step_x16);
471+
FXP_Q4_ARGS(limits->link.min_bpp_x16), FXP_Q4_ARGS(limits->link.max_bpp_x16));
509472

510473
crtc_state->lane_count = limits->max_lane_count;
511474
crtc_state->port_clock = limits->max_rate;
512475

513476
return intel_dp_mtp_tu_compute_config(intel_dp, crtc_state, conn_state,
514-
min_compressed_bpp_x16,
515-
max_compressed_bpp_x16,
516-
bpp_step_x16, true);
477+
limits->link.min_bpp_x16,
478+
limits->link.max_bpp_x16,
479+
intel_dp_dsc_bpp_step_x16(connector),
480+
true);
517481
}
518482

519483
static int mode_hblank_period_ns(const struct drm_display_mode *mode)

0 commit comments

Comments
 (0)