Skip to content

Commit d284389

Browse files
John MadieuMani-Sadhasivam
authored andcommitted
PCI: rzg3s-host: Fix reset handling in probe error path
Fix incorrect reset_control_bulk_deassert() call in the probe error path. When unwinding from a failed pci_host_probe(), the configuration resets should be asserted to restore the hardware to its initial state, not deasserted again. Fixes: 7ef502f ("PCI: Add Renesas RZ/G3S host controller driver") Signed-off-by: John Madieu <john.madieu.xa@bp.renesas.com> Signed-off-by: Manivannan Sadhasivam <mani@kernel.org> Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> # RZ/V2N EVK Tested-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@bp.renesas.com> Link: https://patch.msgid.link/20260306143423.19562-2-john.madieu.xa@bp.renesas.com
1 parent 6de23f8 commit d284389

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/pci/controller/pcie-rzg3s-host.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1589,8 +1589,7 @@ static int rzg3s_pcie_probe(struct platform_device *pdev)
15891589

15901590
host_probe_teardown:
15911591
rzg3s_pcie_teardown_irqdomain(host);
1592-
reset_control_bulk_deassert(host->data->num_cfg_resets,
1593-
host->cfg_resets);
1592+
reset_control_bulk_assert(host->data->num_cfg_resets, host->cfg_resets);
15941593
rpm_put:
15951594
pm_runtime_put_sync(dev);
15961595
rpm_disable:

0 commit comments

Comments
 (0)