Skip to content

Commit d0874a5

Browse files
jankarabrauner
authored andcommitted
udf: Track metadata bhs in fs-private inode part
Track metadata bhs for an inode in fs-private part of the inode. Signed-off-by: Jan Kara <jack@suse.cz> Link: https://patch.msgid.link/20260326095354.16340-80-jack@suse.cz Signed-off-by: Christian Brauner <brauner@kernel.org>
1 parent 4399598 commit d0874a5

9 files changed

Lines changed: 25 additions & 14 deletions

File tree

fs/udf/dir.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -157,6 +157,6 @@ const struct file_operations udf_dir_operations = {
157157
.read = generic_read_dir,
158158
.iterate_shared = udf_readdir,
159159
.unlocked_ioctl = udf_ioctl,
160-
.fsync = generic_buffers_fsync,
160+
.fsync = udf_fsync,
161161
.setlease = generic_setlease,
162162
};

fs/udf/directory.c

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -430,9 +430,10 @@ void udf_fiiter_write_fi(struct udf_fileident_iter *iter, uint8_t *impuse)
430430
if (iinfo->i_alloc_type == ICBTAG_FLAG_AD_IN_ICB) {
431431
mark_inode_dirty(iter->dir);
432432
} else {
433-
mark_buffer_dirty_inode(iter->bh[0], iter->dir);
433+
mmb_mark_buffer_dirty(iter->bh[0], &iinfo->i_metadata_bhs);
434434
if (iter->bh[1])
435-
mark_buffer_dirty_inode(iter->bh[1], iter->dir);
435+
mmb_mark_buffer_dirty(iter->bh[1],
436+
&iinfo->i_metadata_bhs);
436437
}
437438
inode_inc_iversion(iter->dir);
438439
}

fs/udf/file.c

Lines changed: 8 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -198,14 +198,21 @@ static int udf_file_mmap(struct file *file, struct vm_area_struct *vma)
198198
return 0;
199199
}
200200

201+
int udf_fsync(struct file *file, loff_t start, loff_t end, int datasync)
202+
{
203+
return mmb_fsync(file,
204+
&UDF_I(file->f_mapping->host)->i_metadata_bhs,
205+
start, end, datasync);
206+
}
207+
201208
const struct file_operations udf_file_operations = {
202209
.read_iter = generic_file_read_iter,
203210
.unlocked_ioctl = udf_ioctl,
204211
.open = generic_file_open,
205212
.mmap = udf_file_mmap,
206213
.write_iter = udf_file_write_iter,
207214
.release = udf_release_file,
208-
.fsync = generic_buffers_fsync,
215+
.fsync = udf_fsync,
209216
.splice_read = filemap_splice_read,
210217
.splice_write = iter_file_splice_write,
211218
.llseek = generic_file_llseek,

fs/udf/inode.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -155,8 +155,8 @@ void udf_evict_inode(struct inode *inode)
155155
}
156156
truncate_inode_pages_final(&inode->i_data);
157157
if (!want_delete)
158-
sync_mapping_buffers(&inode->i_data);
159-
invalidate_inode_buffers(inode);
158+
mmb_sync(&iinfo->i_metadata_bhs);
159+
mmb_invalidate(&iinfo->i_metadata_bhs);
160160
clear_inode(inode);
161161
kfree(iinfo->i_data);
162162
iinfo->i_data = NULL;
@@ -1263,7 +1263,7 @@ struct buffer_head *udf_bread(struct inode *inode, udf_pblk_t block,
12631263
memset(bh->b_data, 0x00, inode->i_sb->s_blocksize);
12641264
set_buffer_uptodate(bh);
12651265
unlock_buffer(bh);
1266-
mark_buffer_dirty_inode(bh, inode);
1266+
mmb_mark_buffer_dirty(bh, &UDF_I(inode)->i_metadata_bhs);
12671267
return bh;
12681268
}
12691269

@@ -2011,7 +2011,7 @@ int udf_setup_indirect_aext(struct inode *inode, udf_pblk_t block,
20112011
memset(bh->b_data, 0x00, sb->s_blocksize);
20122012
set_buffer_uptodate(bh);
20132013
unlock_buffer(bh);
2014-
mark_buffer_dirty_inode(bh, inode);
2014+
mmb_mark_buffer_dirty(bh, &UDF_I(inode)->i_metadata_bhs);
20152015

20162016
aed = (struct allocExtDesc *)(bh->b_data);
20172017
if (!UDF_QUERY_FLAG(sb, UDF_FLAG_STRICT)) {
@@ -2106,7 +2106,7 @@ int __udf_add_aext(struct inode *inode, struct extent_position *epos,
21062106
else
21072107
udf_update_tag(epos->bh->b_data,
21082108
sizeof(struct allocExtDesc));
2109-
mark_buffer_dirty_inode(epos->bh, inode);
2109+
mmb_mark_buffer_dirty(epos->bh, &iinfo->i_metadata_bhs);
21102110
}
21112111

21122112
return 0;
@@ -2190,7 +2190,7 @@ void udf_write_aext(struct inode *inode, struct extent_position *epos,
21902190
le32_to_cpu(aed->lengthAllocDescs) +
21912191
sizeof(struct allocExtDesc));
21922192
}
2193-
mark_buffer_dirty_inode(epos->bh, inode);
2193+
mmb_mark_buffer_dirty(epos->bh, &iinfo->i_metadata_bhs);
21942194
} else {
21952195
mark_inode_dirty(inode);
21962196
}
@@ -2398,7 +2398,7 @@ int8_t udf_delete_aext(struct inode *inode, struct extent_position epos)
23982398
else
23992399
udf_update_tag(oepos.bh->b_data,
24002400
sizeof(struct allocExtDesc));
2401-
mark_buffer_dirty_inode(oepos.bh, inode);
2401+
mmb_mark_buffer_dirty(oepos.bh, &iinfo->i_metadata_bhs);
24022402
}
24032403
} else {
24042404
udf_write_aext(inode, &oepos, &eloc, elen, 1);
@@ -2415,7 +2415,7 @@ int8_t udf_delete_aext(struct inode *inode, struct extent_position epos)
24152415
else
24162416
udf_update_tag(oepos.bh->b_data,
24172417
sizeof(struct allocExtDesc));
2418-
mark_buffer_dirty_inode(oepos.bh, inode);
2418+
mmb_mark_buffer_dirty(oepos.bh, &iinfo->i_metadata_bhs);
24192419
}
24202420
}
24212421

fs/udf/namei.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -638,7 +638,7 @@ static int udf_symlink(struct mnt_idmap *idmap, struct inode *dir,
638638
memset(epos.bh->b_data, 0x00, bsize);
639639
set_buffer_uptodate(epos.bh);
640640
unlock_buffer(epos.bh);
641-
mark_buffer_dirty_inode(epos.bh, inode);
641+
mmb_mark_buffer_dirty(epos.bh, &iinfo->i_metadata_bhs);
642642
ea = epos.bh->b_data + udf_ext0_offset(inode);
643643
} else
644644
ea = iinfo->i_data + iinfo->i_lenEAttr;

fs/udf/super.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -166,6 +166,7 @@ static struct inode *udf_alloc_inode(struct super_block *sb)
166166
ei->cached_extent.lstart = -1;
167167
spin_lock_init(&ei->i_extent_cache_lock);
168168
inode_set_iversion(&ei->vfs_inode, 1);
169+
mmb_init(&ei->i_metadata_bhs, &ei->vfs_inode.i_data);
169170

170171
return &ei->vfs_inode;
171172
}

fs/udf/truncate.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -186,7 +186,7 @@ static void udf_update_alloc_ext_desc(struct inode *inode,
186186
len += lenalloc;
187187

188188
udf_update_tag(epos->bh->b_data, len);
189-
mark_buffer_dirty_inode(epos->bh, inode);
189+
mmb_mark_buffer_dirty(epos->bh, &UDF_I(inode)->i_metadata_bhs);
190190
}
191191

192192
/*

fs/udf/udf_i.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ struct udf_inode_info {
5050
struct kernel_lb_addr i_locStreamdir;
5151
__u64 i_lenStreams;
5252
struct rw_semaphore i_data_sem;
53+
struct mapping_metadata_bhs i_metadata_bhs;
5354
struct udf_ext_cache cached_extent;
5455
/* Spinlock for protecting extent cache */
5556
spinlock_t i_extent_cache_lock;

fs/udf/udfdecl.h

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -137,6 +137,7 @@ static inline unsigned int udf_dir_entry_len(struct fileIdentDesc *cfi)
137137

138138
/* file.c */
139139
extern long udf_ioctl(struct file *, unsigned int, unsigned long);
140+
int udf_fsync(struct file *file, loff_t start, loff_t end, int datasync);
140141

141142
/* inode.c */
142143
extern struct inode *__udf_iget(struct super_block *, struct kernel_lb_addr *,

0 commit comments

Comments
 (0)