Skip to content

Commit cffff6d

Browse files
bugfoodgroeck
authored andcommitted
hwmon: (asus-ec-sensors) Fix T_Sensor for PRIME X670E-PRO WIFI
On the Asus PRIME X670E-PRO WIFI, the driver reports a constant value of zero for T_Sensor. On this board, the register for T_Sensor is at a different address, as found by experimentation and confirmed by comparison to an independent temperature reading. * sensor disconnected: -62.0°C * ambient temperature: +22.0°C * held between fingers: +30.0°C Introduce SENSOR_TEMP_T_SENSOR_ALT1 to support the PRIME X670E-PRO WIFI without causing a regression for other 600-series boards Fixes: e044475 ("hwmon: (asus-ec-sensors) add PRIME X670E-PRO WIFI") Signed-off-by: Corey Hickey <bugfood-c@fatooh.org> Link: https://lore.kernel.org/r/20260331215414.368785-1-bugfood-ml@fatooh.org [groeck: Fixed typo, updated Fixes: reference] Signed-off-by: Guenter Roeck <linux@roeck-us.net>
1 parent 0977397 commit cffff6d

1 file changed

Lines changed: 6 additions & 1 deletion

File tree

drivers/hwmon/asus-ec-sensors.c

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,8 @@ enum ec_sensors {
111111
ec_sensor_temp_mb,
112112
/* "T_Sensor" temperature sensor reading [℃] */
113113
ec_sensor_temp_t_sensor,
114+
/* like ec_sensor_temp_t_sensor, but at an alternate address [℃] */
115+
ec_sensor_temp_t_sensor_alt1,
114116
/* VRM temperature [℃] */
115117
ec_sensor_temp_vrm,
116118
/* VRM east (right) temperature [℃] */
@@ -160,6 +162,7 @@ enum ec_sensors {
160162
#define SENSOR_TEMP_CPU_PACKAGE BIT(ec_sensor_temp_cpu_package)
161163
#define SENSOR_TEMP_MB BIT(ec_sensor_temp_mb)
162164
#define SENSOR_TEMP_T_SENSOR BIT(ec_sensor_temp_t_sensor)
165+
#define SENSOR_TEMP_T_SENSOR_ALT1 BIT(ec_sensor_temp_t_sensor_alt1)
163166
#define SENSOR_TEMP_VRM BIT(ec_sensor_temp_vrm)
164167
#define SENSOR_TEMP_VRME BIT(ec_sensor_temp_vrme)
165168
#define SENSOR_TEMP_VRMW BIT(ec_sensor_temp_vrmw)
@@ -279,6 +282,8 @@ static const struct ec_sensor_info sensors_family_amd_600[] = {
279282
EC_SENSOR("VRM", hwmon_temp, 1, 0x00, 0x33),
280283
[ec_sensor_temp_t_sensor] =
281284
EC_SENSOR("T_Sensor", hwmon_temp, 1, 0x00, 0x36),
285+
[ec_sensor_temp_t_sensor_alt1] =
286+
EC_SENSOR("T_Sensor", hwmon_temp, 1, 0x00, 0x37),
282287
[ec_sensor_fan_cpu_opt] =
283288
EC_SENSOR("CPU_Opt", hwmon_fan, 2, 0x00, 0xb0),
284289
[ec_sensor_temp_water_in] =
@@ -519,7 +524,7 @@ static const struct ec_board_info board_info_prime_x570_pro = {
519524
static const struct ec_board_info board_info_prime_x670e_pro_wifi = {
520525
.sensors = SENSOR_TEMP_CPU | SENSOR_TEMP_CPU_PACKAGE |
521526
SENSOR_TEMP_MB | SENSOR_TEMP_VRM |
522-
SENSOR_TEMP_T_SENSOR | SENSOR_FAN_CPU_OPT,
527+
SENSOR_TEMP_T_SENSOR_ALT1 | SENSOR_FAN_CPU_OPT,
523528
.mutex_path = ACPI_GLOBAL_LOCK_PSEUDO_PATH,
524529
.family = family_amd_600_series,
525530
};

0 commit comments

Comments
 (0)