Skip to content

Commit ce23158

Browse files
charsyamsmfrench
authored andcommitted
smb: server: fix max_connections off-by-one in tcp accept path
The global max_connections check in ksmbd's TCP accept path counts the newly accepted connection with atomic_inc_return(), but then rejects the connection when the result is greater than or equal to server_conf.max_connections. That makes the effective limit one smaller than configured. For example: - max_connections=1 rejects the first connection - max_connections=2 allows only one connection The per-IP limit in the same function uses <= correctly because it counts only pre-existing connections. The global limit instead checks the post-increment total, so it should reject only when that total exceeds the configured maximum. Fix this by changing the comparison from >= to >, so exactly max_connections simultaneous connections are allowed and the next one is rejected. This matches the documented meaning of max_connections in fs/smb/server/ksmbd_netlink.h as the "Number of maximum simultaneous connections". Fixes: 0d0d468 ("ksmbd: add max connections parameter") Cc: stable@vger.kernel.org Signed-off-by: DaeMyung Kang <charsyam@gmail.com> Acked-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent d07b26f commit ce23158

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

fs/smb/server/transport_tcp.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -281,7 +281,7 @@ static int ksmbd_kthread_fn(void *p)
281281

282282
skip_max_ip_conns_limit:
283283
if (server_conf.max_connections &&
284-
atomic_inc_return(&active_num_conn) >= server_conf.max_connections) {
284+
atomic_inc_return(&active_num_conn) > server_conf.max_connections) {
285285
pr_info_ratelimited("Limit the maximum number of connections(%u)\n",
286286
atomic_read(&active_num_conn));
287287
atomic_dec(&active_num_conn);

0 commit comments

Comments
 (0)