Skip to content

Commit cd3b309

Browse files
tobluxtyhicks
authored andcommitted
ecryptfs: Drop TODO comment in ecryptfs_derive_iv
Remove the TODO from 2006. eCryptfs is generally not receiving new features and changing the IV derivation is only likely to happen to address security concerns in the future. Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> [tyhicks: Add the reasoning to the commit message] Signed-off-by: Tyler Hicks <code@tyhicks.com>
1 parent c8717a7 commit cd3b309

1 file changed

Lines changed: 0 additions & 4 deletions

File tree

fs/ecryptfs/crypto.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -89,10 +89,6 @@ void ecryptfs_derive_iv(char *iv, struct ecryptfs_crypt_stat *crypt_stat,
8989
ecryptfs_printk(KERN_DEBUG, "root iv:\n");
9090
ecryptfs_dump_hex(crypt_stat->root_iv, crypt_stat->iv_bytes);
9191
}
92-
/* TODO: It is probably secure to just cast the least
93-
* significant bits of the root IV into an unsigned long and
94-
* add the offset to that rather than go through all this
95-
* hashing business. -Halcrow */
9692
memcpy(src, crypt_stat->root_iv, crypt_stat->iv_bytes);
9793
memset((src + crypt_stat->iv_bytes), 0, 16);
9894
snprintf((src + crypt_stat->iv_bytes), 16, "%lld", offset);

0 commit comments

Comments
 (0)