Skip to content

Commit c9c99b7

Browse files
zhangjian3032cminyard
authored andcommitted
ipmi: ssif_bmc: change log level to dbg in irq callback
Long-running tests indicate that this logging can occasionally disrupt timing and lead to request/response corruption. Irq handler need to be executed as fast as possible, most I2C slave IRQ implementations are byte-level, logging here can significantly affect transfer behavior and timing. It is recommended to use dev_dbg() for these messages. Fixes: dd2bc5c ("ipmi: ssif_bmc: Add SSIF BMC driver") Signed-off-by: Jian Zhang <zhangjian.3032@bytedance.com> Message-ID: <20260403090603.3988423-4-zhangjian.3032@bytedance.com> Signed-off-by: Corey Minyard <corey@minyard.net>
1 parent 1d38e84 commit c9c99b7

1 file changed

Lines changed: 9 additions & 9 deletions

File tree

drivers/char/ipmi/ssif_bmc.c

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -569,7 +569,7 @@ static void process_request_part(struct ssif_bmc_ctx *ssif_bmc)
569569
len = ssif_bmc->request.len + part->length;
570570
/* Do the bound check here, not allow the request len exceed 254 bytes */
571571
if (len > IPMI_SSIF_PAYLOAD_MAX) {
572-
dev_warn(&ssif_bmc->client->dev,
572+
dev_dbg(&ssif_bmc->client->dev,
573573
"Warn: Request exceeded 254 bytes, aborting");
574574
/* Request too long, aborting */
575575
ssif_bmc->aborting = true;
@@ -615,7 +615,7 @@ static void on_read_requested_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val)
615615
ssif_bmc->state == SSIF_START ||
616616
ssif_bmc->state == SSIF_REQ_RECVING ||
617617
ssif_bmc->state == SSIF_RES_SENDING) {
618-
dev_warn(&ssif_bmc->client->dev,
618+
dev_dbg(&ssif_bmc->client->dev,
619619
"Warn: %s unexpected READ REQUESTED in state=%s\n",
620620
__func__, state_to_string(ssif_bmc->state));
621621
ssif_bmc->state = SSIF_ABORTING;
@@ -624,7 +624,7 @@ static void on_read_requested_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val)
624624

625625
} else if (ssif_bmc->state == SSIF_SMBUS_CMD) {
626626
if (!supported_read_cmd(ssif_bmc->part_buf.smbus_cmd)) {
627-
dev_warn(&ssif_bmc->client->dev, "Warn: Unknown SMBus read command=0x%x",
627+
dev_dbg(&ssif_bmc->client->dev, "Warn: Unknown SMBus read command=0x%x",
628628
ssif_bmc->part_buf.smbus_cmd);
629629
ssif_bmc->aborting = true;
630630
}
@@ -659,7 +659,7 @@ static void on_read_processed_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val)
659659
ssif_bmc->state == SSIF_START ||
660660
ssif_bmc->state == SSIF_REQ_RECVING ||
661661
ssif_bmc->state == SSIF_SMBUS_CMD) {
662-
dev_warn(&ssif_bmc->client->dev,
662+
dev_dbg(&ssif_bmc->client->dev,
663663
"Warn: %s unexpected READ PROCESSED in state=%s\n",
664664
__func__, state_to_string(ssif_bmc->state));
665665
ssif_bmc->state = SSIF_ABORTING;
@@ -684,7 +684,7 @@ static void on_write_requested_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val)
684684
} else if (ssif_bmc->state == SSIF_START ||
685685
ssif_bmc->state == SSIF_REQ_RECVING ||
686686
ssif_bmc->state == SSIF_RES_SENDING) {
687-
dev_warn(&ssif_bmc->client->dev,
687+
dev_dbg(&ssif_bmc->client->dev,
688688
"Warn: %s unexpected WRITE REQUEST in state=%s\n",
689689
__func__, state_to_string(ssif_bmc->state));
690690
ssif_bmc->state = SSIF_ABORTING;
@@ -699,7 +699,7 @@ static void on_write_received_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val)
699699
{
700700
if (ssif_bmc->state == SSIF_READY ||
701701
ssif_bmc->state == SSIF_RES_SENDING) {
702-
dev_warn(&ssif_bmc->client->dev,
702+
dev_dbg(&ssif_bmc->client->dev,
703703
"Warn: %s unexpected WRITE RECEIVED in state=%s\n",
704704
__func__, state_to_string(ssif_bmc->state));
705705
ssif_bmc->state = SSIF_ABORTING;
@@ -709,7 +709,7 @@ static void on_write_received_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val)
709709

710710
} else if (ssif_bmc->state == SSIF_SMBUS_CMD) {
711711
if (!supported_write_cmd(ssif_bmc->part_buf.smbus_cmd)) {
712-
dev_warn(&ssif_bmc->client->dev, "Warn: Unknown SMBus write command=0x%x",
712+
dev_dbg(&ssif_bmc->client->dev, "Warn: Unknown SMBus write command=0x%x",
713713
ssif_bmc->part_buf.smbus_cmd);
714714
ssif_bmc->aborting = true;
715715
}
@@ -738,7 +738,7 @@ static void on_stop_event(struct ssif_bmc_ctx *ssif_bmc, u8 *val)
738738
ssif_bmc->state == SSIF_START ||
739739
ssif_bmc->state == SSIF_SMBUS_CMD ||
740740
ssif_bmc->state == SSIF_ABORTING) {
741-
dev_warn(&ssif_bmc->client->dev,
741+
dev_dbg(&ssif_bmc->client->dev,
742742
"Warn: %s unexpected SLAVE STOP in state=%s\n",
743743
__func__, state_to_string(ssif_bmc->state));
744744
ssif_bmc->state = SSIF_READY;
@@ -805,7 +805,7 @@ static int ssif_bmc_cb(struct i2c_client *client, enum i2c_slave_event event, u8
805805
break;
806806

807807
default:
808-
dev_warn(&ssif_bmc->client->dev, "Warn: Unknown i2c slave event\n");
808+
dev_dbg(&ssif_bmc->client->dev, "Warn: Unknown i2c slave event\n");
809809
break;
810810
}
811811

0 commit comments

Comments
 (0)