spi: sn-f-ospi: fix incorrect return code for invalid num-cs

outman119 · broonie · commit c4c3fc872d2a · 2026-04-11T12:58:16.000+01:00
Returning -ENOMEM for an invalid num-cs value is semantically wrong. Use -EINVAL instead. Signed-off-by: Felix Gu <ustc.gu@gmail.com> Link: https://patch.msgid.link/20260411-ispi-v1-1-af384e81c4c8@gmail.com Signed-off-by: Mark Brown <broonie@kernel.org>
diff --git a/drivers/spi/spi-sn-f-ospi.c b/drivers/spi/spi-sn-f-ospi.c
@@ -625,7 +625,7 @@ static int f_ospi_probe(struct platform_device *pdev)
 	of_property_read_u32(dev->of_node, "num-cs", &num_cs);
 	if (num_cs > OSPI_NUM_CS) {
 		dev_err(dev, "num-cs too large: %d\n", num_cs);
-		return -ENOMEM;
+		return -EINVAL;
 	}
 	ctlr->num_chipselect = num_cs;
 

Original file line number	Diff line number	Diff line change
`@@ -625,7 +625,7 @@ static int f_ospi_probe(struct platform_device *pdev)`
`625`	`625`	`of_property_read_u32(dev->of_node, "num-cs", &num_cs);`
`626`	`626`	`if (num_cs > OSPI_NUM_CS) {`
`627`	`627`	`dev_err(dev, "num-cs too large: %d\n", num_cs);`
`628`		`- return -ENOMEM;`
	`628`	`+ return -EINVAL;`
`629`	`629`	`}`
`630`	`630`	`ctlr->num_chipselect = num_cs;`
`631`	`631`