Skip to content

Commit bfef062

Browse files
jhovoldthierryreding
authored andcommitted
drm/tegra: dsi: fix device leak on probe
Make sure to drop the reference taken when looking up the companion (ganged) device and its driver data during probe(). Note that holding a reference to a device does not prevent its driver data from going away so there is no point in keeping the reference. Fixes: e94236c ("drm/tegra: dsi: Add ganged mode support") Fixes: 221e363 ("drm/tegra: Fix reference leak in tegra_dsi_ganged_probe") Cc: stable@vger.kernel.org # 3.19: 221e363 Cc: Thierry Reding <treding@nvidia.com> Signed-off-by: Johan Hovold <johan@kernel.org> Signed-off-by: Thierry Reding <treding@nvidia.com> Link: https://patch.msgid.link/20251121164201.13188-1-johan@kernel.org
1 parent cd98e73 commit bfef062

1 file changed

Lines changed: 2 additions & 4 deletions

File tree

  • drivers/gpu/drm/tegra

drivers/gpu/drm/tegra/dsi.c

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1542,11 +1542,9 @@ static int tegra_dsi_ganged_probe(struct tegra_dsi *dsi)
15421542
return -EPROBE_DEFER;
15431543

15441544
dsi->slave = platform_get_drvdata(gangster);
1545-
1546-
if (!dsi->slave) {
1547-
put_device(&gangster->dev);
1545+
put_device(&gangster->dev);
1546+
if (!dsi->slave)
15481547
return -EPROBE_DEFER;
1549-
}
15501548

15511549
dsi->slave->master = dsi;
15521550
}

0 commit comments

Comments
 (0)