Skip to content

Commit bccaf98

Browse files
MaxKrummenachernxpfrankli
authored andcommitted
Revert "ARM: dts: imx: move nand related property under nand@0"
This reverts commit 8124b4a. The change introduced a regression: at least Colibri iMX6ULL and Colibri iMX7 no longer boot with that commit applied, while they boot again after reverting it. Although this has only been verified on these two modules, the issue is expected to affect all device trees using the gpmi-nand driver. [ 0.876938] Creating 5 MTD partitions on "gpmi-nand": [ 0.876974] 0x000000000000-0x000000080000 : "mx7-bcb" [ 0.879860] 0x000000080000-0x000000200000 : "u-boot1" [ 0.884761] 0x000000200000-0x000000380000 : "u-boot2" [ 0.886993] 0x000000380000-0x000000400000 : "u-boot-env" [ 0.894686] 0x000000400000-0x000020000000 : "ubi" [ 0.899054] gpmi-nand 33002000.nand-controller: driver registered. ... [ 0.960443] ubi0: default fastmap pool size: 200 [ 0.960476] ubi0: default fastmap WL pool size: 100 [ 0.960500] ubi0: attaching mtd4 [ 1.636355] ubi0 error: scan_peb: bad image sequence number 1588722158 in PEB 4060, expected 1574791632 ... [ 1.649889] ubi0 error: ubi_attach_mtd_dev: failed to attach mtd4, error -22 [ 1.650029] UBI error: cannot attach mtd4 ... [ 1.670262] Kernel panic - not syncing: VFS: Unable to mount root fs on unknown-block(0,253) Fixes: 8124b4a ("ARM: dts: imx: move nand related property under nand@0") Signed-off-by: Max Krummenacher <max.krummenacher@toradex.com> Signed-off-by: Frank Li <Frank.Li@nxp.com>
1 parent b6c94c7 commit bccaf98

15 files changed

Lines changed: 22 additions & 82 deletions

arch/arm/boot/dts/nxp/imx/imx6-logicpd-som.dtsi

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -36,12 +36,8 @@
3636
&gpmi {
3737
pinctrl-names = "default";
3838
pinctrl-0 = <&pinctrl_gpmi_nand>;
39+
nand-on-flash-bbt;
3940
status = "okay";
40-
41-
nand@0 {
42-
reg = <0>;
43-
nand-on-flash-bbt;
44-
};
4541
};
4642

4743
&i2c3 {

arch/arm/boot/dts/nxp/imx/imx6qdl-icore.dtsi

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -172,12 +172,8 @@
172172
&gpmi {
173173
pinctrl-names = "default";
174174
pinctrl-0 = <&pinctrl_gpmi_nand>;
175+
nand-on-flash-bbt;
175176
status = "okay";
176-
177-
nand@0 {
178-
reg = <0>;
179-
nand-on-flash-bbt;
180-
};
181177
};
182178

183179
&i2c1 {

arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-pfla02.dtsi

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -102,12 +102,8 @@
102102
&gpmi {
103103
pinctrl-names = "default";
104104
pinctrl-0 = <&pinctrl_gpmi_nand>;
105+
nand-on-flash-bbt;
105106
status = "okay";
106-
107-
nand@0 {
108-
reg = <0>;
109-
nand-on-flash-bbt;
110-
};
111107
};
112108

113109
&i2c1 {

arch/arm/boot/dts/nxp/imx/imx6qdl-phytec-phycore-som.dtsi

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -73,12 +73,8 @@
7373
&gpmi {
7474
pinctrl-names = "default";
7575
pinctrl-0 = <&pinctrl_gpmi_nand>;
76+
nand-on-flash-bbt;
7677
status = "disabled";
77-
78-
nand@0 {
79-
reg = <0>;
80-
nand-on-flash-bbt;
81-
};
8278
};
8379

8480
&i2c3 {

arch/arm/boot/dts/nxp/imx/imx6qdl-skov-cpu.dtsi

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -260,14 +260,10 @@
260260
&gpmi {
261261
pinctrl-names = "default";
262262
pinctrl-0 = <&pinctrl_gpmi_nand>;
263+
nand-on-flash-bbt;
263264
#address-cells = <1>;
264265
#size-cells = <0>;
265266
status = "okay";
266-
267-
nand@0 {
268-
reg = <0>;
269-
nand-on-flash-bbt;
270-
};
271267
};
272268

273269
&i2c3 {

arch/arm/boot/dts/nxp/imx/imx6qdl-tx6.dtsi

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -252,13 +252,9 @@
252252
&gpmi {
253253
pinctrl-names = "default";
254254
pinctrl-0 = <&pinctrl_gpmi_nand>;
255+
nand-on-flash-bbt;
255256
fsl,no-blockmark-swap;
256257
status = "okay";
257-
258-
nand@0 {
259-
reg = <0>;
260-
nand-on-flash-bbt;
261-
};
262258
};
263259

264260
&i2c1 {

arch/arm/boot/dts/nxp/imx/imx6ul-geam.dts

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -133,12 +133,8 @@
133133
&gpmi {
134134
pinctrl-names = "default";
135135
pinctrl-0 = <&pinctrl_gpmi_nand>;
136+
nand-on-flash-bbt;
136137
status = "okay";
137-
138-
nand@0 {
139-
reg = <0>;
140-
nand-on-flash-bbt;
141-
};
142138
};
143139

144140
&i2c1 {

arch/arm/boot/dts/nxp/imx/imx6ul-isiot.dtsi

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -101,12 +101,8 @@
101101
&gpmi {
102102
pinctrl-names = "default";
103103
pinctrl-0 = <&pinctrl_gpmi_nand>;
104+
nand-on-flash-bbt;
104105
status = "disabled";
105-
106-
nand@0 {
107-
reg = <0>;
108-
nand-on-flash-bbt;
109-
};
110106
};
111107

112108
&i2c1 {

arch/arm/boot/dts/nxp/imx/imx6ul-phytec-phycore-som.dtsi

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -63,12 +63,8 @@
6363
&gpmi {
6464
pinctrl-names = "default";
6565
pinctrl-0 = <&pinctrl_gpmi_nand>;
66+
nand-on-flash-bbt;
6667
status = "disabled";
67-
68-
nand@0 {
69-
reg = <0>;
70-
nand-on-flash-bbt;
71-
};
7268
};
7369

7470
&i2c1 {

arch/arm/boot/dts/nxp/imx/imx6ul-tx6ul.dtsi

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -296,13 +296,9 @@
296296
&gpmi {
297297
pinctrl-names = "default";
298298
pinctrl-0 = <&pinctrl_gpmi_nand>;
299+
nand-on-flash-bbt;
299300
fsl,no-blockmark-swap;
300301
status = "okay";
301-
302-
nand@0 {
303-
reg = <0>;
304-
nand-on-flash-bbt;
305-
};
306302
};
307303

308304
&i2c2 {

0 commit comments

Comments
 (0)