Skip to content

Commit baf28ec

Browse files
Timur Kristófalexdeucher
authored andcommitted
drm/amd/pm/ci: Fill DW8 fields from SMC
In ci_populate_dw8() we currently just read a value from the SMU and then throw it away. Instead of throwing away the value, we should use it to fill other fields in DW8 (like radeon). Otherwise the value of the other fiels is just cleared when we copy this data to the SMU later. Fixes: 9f4b354 ("drm/amd/powerplay: add CI asics support to smumgr (v3)") Signed-off-by: Timur Kristóf <timur.kristof@gmail.com> Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
1 parent 5facfd4 commit baf28ec

1 file changed

Lines changed: 1 addition & 2 deletions

File tree

drivers/gpu/drm/amd/pm/powerplay/smumgr/ci_smumgr.c

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -543,12 +543,11 @@ static int ci_populate_dw8(struct pp_hwmgr *hwmgr, uint32_t fuse_table_offset)
543543
{
544544
struct ci_smumgr *smu_data = (struct ci_smumgr *)(hwmgr->smu_backend);
545545
const struct ci_pt_defaults *defaults = smu_data->power_tune_defaults;
546-
uint32_t temp;
547546

548547
if (ci_read_smc_sram_dword(hwmgr,
549548
fuse_table_offset +
550549
offsetof(SMU7_Discrete_PmFuses, TdcWaterfallCtl),
551-
(uint32_t *)&temp, SMC_RAM_END))
550+
(uint32_t *)&smu_data->power_tune_table.TdcWaterfallCtl, SMC_RAM_END))
552551
PP_ASSERT_WITH_CODE(false,
553552
"Attempt to read PmFuses.DW6 (SviLoadLineEn) from SMC Failed!",
554553
return -EINVAL);

0 commit comments

Comments
 (0)